Bug 182957 - Make more use of USE(OPENGL_ES) where it makes sense
Summary: Make more use of USE(OPENGL_ES) where it makes sense
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-19 23:31 PST by Tim Horton
Modified: 2018-02-20 15:34 PST (History)
8 users (show)

See Also:

Attachments
Patch (13.08 KB, patch)
2018-02-19 23:32 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (13.34 KB, patch)
2018-02-20 12:04 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-02-19 23:31:52 PST 
Make more use of USE(OPENGL_ES) where it makes sense
Comment 1 Tim Horton 2018-02-19 23:32:20 PST 
Created attachment 334247 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-02-19 23:37:39 PST 
<rdar://problem/37699443>
Comment 3 mitz 2018-02-19 23:42:18 PST 
Comment on attachment 334247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334247&action=review

> Source/WebCore/platform/graphics/GraphicsContext3D.h:64
> +#else // PLATFORM(COCOA)

This is confusing. Maybe just #endif // PLATFORM(COCOA) then #if !PLATFORM(COCOA)?

> Source/WebCore/platform/graphics/GraphicsContext3D.h:66
> +#endif // PLATFORM(COCOA)

Confusing.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:72
> +#else // __OBJC__

Also.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:80
> +#else // PLATFORM(COCOA)

As well.
Comment 4 Tim Horton 2018-02-19 23:44:54 PST 
Interesting! I feel like there was once a webkit-dev debate about this :) No idea how it was resolved, but your solution sounds reasonable to me.
Comment 5 Tim Horton 2018-02-20 12:04:52 PST 
Created attachment 334292 [details]
Patch
Comment 6 WebKit Commit Bot 2018-02-20 15:34:05 PST 
Comment on attachment 334292 [details]
Patch

Clearing flags on attachment: 334292

Committed r228849: <https://trac.webkit.org/changeset/228849>
Comment 7 WebKit Commit Bot 2018-02-20 15:34:07 PST 
All reviewed patches have been landed.  Closing bug.