Bug 182956 – [GTK] jhbuild: Remove gtk-doc

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Fujii Hironori]

[GTK] jhbuild: Remove gtk-doc

According to Bug 163102, WebKitGTK+ needs gtk-doc 1.25 or newer.
gtk-doc is a development dependency. and major LTS Linux distro has gtk-doc 1.25.

  Debian 9: 1.25
  https://packages.debian.org/stretch/gtk-doc-tools
  
  Ubuntu 16.04: 1.25
  https://packages.ubuntu.com/xenial/gtk-doc-tools
  
  CentOS 7: 1.25
  http://mirror.centos.org/centos/7/os/x86_64/Packages/

Tools/gtk/install-dependencies already installs gtk-doc.

[Fujii Hironori]

If following warnings are annoying, you can modify your system gtk-doc.

> Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424.
> Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424.
> Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424.
> Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 424.
> Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 917.
> Negative repeat count does nothing at /usr/bin/gtkdoc-mkdb line 3812, <INPUT> line 987.

> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/(.*?){ <-- HERE / at /usr/bin/gtkdoc-scan line 735.

I created a patch https://gist.github.com/fujii/9aa8ebc99ab4662adaef567424ea3453
based on https://github.com/GNOME/gtk-doc/commit/2f968fede39732677efaac205fb8f1e9ae46d90e

[Fujii Hironori]

Created attachment 334249 [details]
Patch

[Michael Catanzaro]

Comment on attachment 334249 [details]
Patch

OK, this seems like a good idea. If it causes trouble, we can always put it back.

[WebKit Commit Bot]

Comment on attachment 334249 [details]
Patch

Rejecting attachment 334249 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334249, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://webkit-queues.webkit.org/results/6592288

[Michael Catanzaro]

Comment on attachment 334249 [details]
Patch

I might need to land it manually. Let's see if commit-queue is fixed yet....

[WebKit Commit Bot]

Comment on attachment 334249 [details]
Patch

Clearing flags on attachment: 334249

Committed r228855: <https://trac.webkit.org/changeset/228855>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.