I find it annoying that when I select a Canvas from the overview, it automatically selects the first recording, causing the recording preview to be shown instead of the current content. We should change this to be where we only select a recording when we are directly viewing a recording (e.g. when a recording finishes or if the user selects one from the menu in the overview).
Created attachment 334215 [details] Patch
Created attachment 334216 [details] [Image] After Patch is applied
Comment on attachment 334215 [details] Patch I'd like to see this behavior pushed into ScopeBar itself. ScopeBar's constructor takes a defaultItem, which AFAIK is never null (although we don't assert this). You could refactor ScopeBar to allow it to be null, and use ScopeBar.prototype.resetToDefault whenever you want to set the selection to none.
(In reply to Matt Baker from comment #3) > Comment on attachment 334215 [details] > Patch > > I'd like to see this behavior pushed into ScopeBar itself. ScopeBar's > constructor takes a defaultItem, which AFAIK is never null (although we > don't assert this). You could refactor ScopeBar to allow it to be null, and > use ScopeBar.prototype.resetToDefault whenever you want to set the selection > to none. My worry about doing this is that it would break other uses of `WI.ScopeBar`, as I don't think any of them currently support a non-selectable default item (or even want that functionality). It might be worth doing as a followup, but I'm not sure how applicable it would be elsewhere.
Comment on attachment 334215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334215&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:42 > + this._canvasTreeOutline.allowsRepeatSelection = true; I think this change deserves an explanation in the change log.
Comment on attachment 334215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334215&action=review >> Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:42 >> + this._canvasTreeOutline.allowsRepeatSelection = true; > > I think this change deserves an explanation in the change log. I'm not actually sure why this was there 😅. I tried removing it and found no difference.
Created attachment 340366 [details] Patch
Comment on attachment 340366 [details] Patch Clearing flags on attachment: 340366 Committed r231773: <https://trac.webkit.org/changeset/231773>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40237015>