Bug 182947 - [RenderTreeBuilder] Move RenderFullScreen::willBeRemoved() mutation logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderFullScreen::willBeRemoved() mutation logic to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-19 16:46 PST by zalan
Modified: 2018-02-21 00:25 PST (History)
8 users (show)

See Also:

Attachments
Patch (13.79 KB, patch)
2018-02-19 17:17 PST, zalan 		koivisto: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.69 MB, application/zip)
2018-02-19 17:55 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.18 MB, application/zip)
2018-02-19 18:27 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews117 for mac-sierra (2.71 MB, application/zip)
2018-02-19 18:48 PST, EWS Watchlist 		no flags Details
Patch (14.45 KB, patch)
2018-02-19 22:08 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.57 KB, patch)
2018-02-20 21:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.88 KB, patch)
2018-02-20 21:43 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-19 16:46:29 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-19 16:46:57 PST 
<rdar://problem/37690848>
Comment 2 zalan 2018-02-19 17:17:34 PST 
Created attachment 334207 [details]
Patch
Comment 3 EWS Watchlist 2018-02-19 17:55:47 PST 
Comment on attachment 334207 [details]
Patch

Attachment 334207 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6581030

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-02-19 17:55:48 PST 
Created attachment 334217 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-02-19 18:27:02 PST 
Comment on attachment 334207 [details]
Patch

Attachment 334207 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6581641

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2018-02-19 18:27:04 PST 
Created attachment 334222 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-02-19 18:48:16 PST 
Comment on attachment 334207 [details]
Patch

Attachment 334207 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6581759

Number of test failures exceeded the failure limit.
Comment 8 EWS Watchlist 2018-02-19 18:48:17 PST 
Created attachment 334225 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 zalan 2018-02-19 22:08:47 PST 
Created attachment 334242 [details]
Patch
Comment 10 zalan 2018-02-20 21:16:06 PST 
Created attachment 334339 [details]
Patch
Comment 11 zalan 2018-02-20 21:43:19 PST 
Created attachment 334340 [details]
Patch
Comment 12 WebKit Commit Bot 2018-02-21 00:25:44 PST 
Comment on attachment 334340 [details]
Patch

Clearing flags on attachment: 334340

Committed r228862: <https://trac.webkit.org/changeset/228862>
Comment 13 WebKit Commit Bot 2018-02-21 00:25:46 PST 
All reviewed patches have been landed.  Closing bug.