Bug 182943 - [RenderTreeBuilder] Move RenderListItem::willBeRemoved() mutation logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderListItem::willBeRemoved() mutation logic to Re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-19 15:51 PST by zalan
Modified: 2018-02-20 20:39 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.65 KB, patch)
2018-02-19 15:52 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2018-02-19 16:15 PST, zalan
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.63 MB, application/zip)
2018-02-19 17:21 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews114 for mac-sierra (2.97 MB, application/zip)
2018-02-19 17:35 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.29 MB, application/zip)
2018-02-19 17:44 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews201 for win-future (11.54 MB, application/zip)
2018-02-19 17:59 PST, EWS Watchlist
no flags Details
Patch (2.35 KB, patch)
2018-02-20 20:00 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-19 15:51:01 PST
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-19 15:51:34 PST
<rdar://problem/37689029>
Comment 2 zalan 2018-02-19 15:52:41 PST
Created attachment 334197 [details]
Patch
Comment 3 zalan 2018-02-19 16:15:08 PST
Created attachment 334199 [details]
Patch
Comment 4 EWS Watchlist 2018-02-19 17:21:36 PST
Comment on attachment 334199 [details]
Patch

Attachment 334199 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6580346

New failing tests:
fast/multicol/newmulticol/change-spanner-display.html
Comment 5 EWS Watchlist 2018-02-19 17:21:37 PST
Created attachment 334208 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-02-19 17:35:46 PST
Comment on attachment 334199 [details]
Patch

Attachment 334199 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6580008

New failing tests:
fast/multicol/newmulticol/change-spanner-display.html
Comment 7 EWS Watchlist 2018-02-19 17:35:47 PST
Created attachment 334209 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-02-19 17:44:36 PST
Comment on attachment 334199 [details]
Patch

Attachment 334199 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6580466

New failing tests:
fast/multicol/newmulticol/change-spanner-display.html
Comment 9 EWS Watchlist 2018-02-19 17:44:38 PST
Created attachment 334214 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-02-19 17:58:45 PST
Comment on attachment 334199 [details]
Patch

Attachment 334199 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6580890

New failing tests:
fast/multicol/newmulticol/change-spanner-display.html
Comment 11 EWS Watchlist 2018-02-19 17:59:17 PST
Created attachment 334218 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 12 zalan 2018-02-20 20:00:15 PST
Created attachment 334337 [details]
Patch
Comment 13 WebKit Commit Bot 2018-02-20 20:39:33 PST
Comment on attachment 334337 [details]
Patch

Clearing flags on attachment: 334337

Committed r228858: <https://trac.webkit.org/changeset/228858>
Comment 14 WebKit Commit Bot 2018-02-20 20:39:35 PST
All reviewed patches have been landed.  Closing bug.