Bug 182939 - [Web Animations] Decouple parsing JS keyframes and computing blending keyframes
Summary: [Web Animations] Decouple parsing JS keyframes and computing blending keyframes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 182741
  Show dependency tree / graph
 
Reported: 2018-02-19 13:40 PST by Antoine Quint
Modified: 2018-02-19 14:01 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.17 KB, patch)
2018-02-19 13:43 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-19 13:40:39 PST 
Currently in KeyframeEffectReadOnly::processKeyframes() we parse JS keyframes into the m_parsedKeyframes member and compute blending keyframes, a KeyframeList, and store it in m_blendingKeyframes. Paving the way towards nullable targets (webkit.org/b/182741) and reading keyframes from a CSSKeyframesRule, we need to decouple those two tasks.
Comment 1 Antoine Quint 2018-02-19 13:40:48 PST 
<rdar://problem/37678364>
Comment 2 Antoine Quint 2018-02-19 13:43:32 PST 
Created attachment 334183 [details]
Patch
Comment 3 Antoine Quint 2018-02-19 14:01:56 PST 
Committed r228710: <https://trac.webkit.org/changeset/228710>