Bug 182926 - [RenderTreeBuilder] Remove redundant RenderObject::removeFromParentAndDestroy
Summary: [RenderTreeBuilder] Remove redundant RenderObject::removeFromParentAndDestroy
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2018-02-19 09:57 PST by zalan
Modified: 2018-02-19 11:03 PST (History)
6 users (show)

See Also:

Patch (15.97 KB, patch)
2018-02-19 10:02 PST, zalan
koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-19 09:57:27 PST
call removeAndDestroyChild directly instead.
Comment 1 Radar WebKit Bug Importer 2018-02-19 09:58:10 PST
Comment 2 zalan 2018-02-19 10:02:27 PST
Created attachment 334162 [details]
Comment 3 WebKit Commit Bot 2018-02-19 10:47:21 PST
Comment on attachment 334162 [details]

Rejecting attachment 334162 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334162, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://webkit-queues.webkit.org/results/6574637
Comment 4 zalan 2018-02-19 11:03:43 PST
Committed r228701: <https://trac.webkit.org/changeset/228701>