Bug 182921 - Support OffscreenCanvas as a CanvasImageSource type in CanvasDrawImage, CanvasFillStrokeStyles
Summary: Support OffscreenCanvas as a CanvasImageSource type in CanvasDrawImage, Canva...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on: 182686
Blocks: 183720
  Show dependency tree / graph
 
Reported: 2018-02-19 00:59 PST by Zan Dobersek
Modified: 2019-11-25 10:16 PST (History)
20 users (show)

See Also:

Attachments
WIP patch (9.96 KB, patch)
2018-02-19 01:00 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (72.92 KB, patch)
2019-10-10 03:15 PDT, Chris Lord 		no flags Details | Formatted Diff | Diff
Patch (72.59 KB, patch)
2019-11-25 09:22 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-02-19 00:59:27 PST 
OffscreenCanvas should be listed in the CanvasImageSource typedef in CanvasDrawImage.idl and CanvasFillStrokeStyles.idl.

Implementation-wise, all of the code is already there, but it has to be broadened from covering only HTMLCanvasElement objects to covering CanvasBase instead.
Comment 1 Zan Dobersek 2018-02-19 01:00:47 PST 
Created attachment 334142 [details]
WIP patch
Comment 2 Chris Lord 2019-10-10 03:15:57 PDT 
Created attachment 380625 [details]
Patch
Comment 3 Chris Lord 2019-11-25 09:22:19 PST 
Created attachment 384301 [details]
Patch
Comment 4 Antti Koivisto 2019-11-25 09:31:56 PST 
Comment on attachment 384301 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2019-11-25 10:15:57 PST 
Comment on attachment 384301 [details]
Patch

Clearing flags on attachment: 384301

Committed r252864: <https://trac.webkit.org/changeset/252864>
Comment 6 WebKit Commit Bot 2019-11-25 10:16:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-25 10:16:26 PST 
<rdar://problem/57475517>