RESOLVED FIXED 182910
REGRESSION (r219342): Touch event coordinates and elementFromPoint coordinates differ
https://bugs.webkit.org/show_bug.cgi?id=182910
Summary REGRESSION (r219342): Touch event coordinates and elementFromPoint coordinate...
Tim Horton
Reported 2018-02-17 23:05:15 PST
REGRESSION (r219342): Touch event coordinates and elementFromPoint coordinates differ
Attachments
Patch (10.01 KB, patch)
2018-02-17 23:05 PST, Tim Horton
no flags
Archive of layout-test-results from ews102 for mac-sierra (2.21 MB, application/zip)
2018-02-18 00:05 PST, EWS Watchlist
no flags
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.57 MB, application/zip)
2018-02-18 00:11 PST, EWS Watchlist
no flags
Archive of layout-test-results from ews113 for mac-sierra (2.92 MB, application/zip)
2018-02-18 00:30 PST, EWS Watchlist
no flags
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.15 MB, application/zip)
2018-02-18 00:37 PST, EWS Watchlist
no flags
Archive of layout-test-results from ews202 for win-future (11.59 MB, application/zip)
2018-02-18 00:51 PST, EWS Watchlist
no flags
Patch (6.40 KB, patch)
2018-02-19 12:15 PST, Tim Horton
no flags
Patch (14.45 KB, patch)
2018-02-19 13:22 PST, Tim Horton
no flags
Tim Horton
Comment 1 2018-02-17 23:05:27 PST
EWS Watchlist
Comment 2 2018-02-18 00:05:54 PST Comment hidden (obsolete)
EWS Watchlist
Comment 3 2018-02-18 00:05:55 PST Comment hidden (obsolete)
EWS Watchlist
Comment 4 2018-02-18 00:11:37 PST Comment hidden (obsolete)
EWS Watchlist
Comment 5 2018-02-18 00:11:38 PST Comment hidden (obsolete)
EWS Watchlist
Comment 6 2018-02-18 00:30:21 PST Comment hidden (obsolete)
EWS Watchlist
Comment 7 2018-02-18 00:30:22 PST Comment hidden (obsolete)
EWS Watchlist
Comment 8 2018-02-18 00:37:15 PST Comment hidden (obsolete)
EWS Watchlist
Comment 9 2018-02-18 00:37:16 PST Comment hidden (obsolete)
EWS Watchlist
Comment 10 2018-02-18 00:50:39 PST Comment hidden (obsolete)
EWS Watchlist
Comment 11 2018-02-18 00:51:01 PST Comment hidden (obsolete)
Simon Fraser (smfr)
Comment 12 2018-02-19 10:43:57 PST
Comment on attachment 334116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334116&action=review > Source/WebCore/ChangeLog:12 > + We reverted other changes to the definition of client coordinates > + in r219829 due to compatibility concerns. However, we failed to revert > + r219342 on trunk, leaving elementFromPoint() using coordinates relative > + to the layout viewport. I think the right thing to do here is to add a settings, like "clientCoordinatesRelativeToLayoutViewport", and make all these changes conditional. Layout-viewport-relative coords are the future, so we should skate etc.
Tim Horton
Comment 13 2018-02-19 10:55:50 PST
(In reply to Simon Fraser (smfr) from comment #12) > Comment on attachment 334116 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334116&action=review > > > Source/WebCore/ChangeLog:12 > > + We reverted other changes to the definition of client coordinates > > + in r219829 due to compatibility concerns. However, we failed to revert > > + r219342 on trunk, leaving elementFromPoint() using coordinates relative > > + to the layout viewport. > > I think the right thing to do here is to add a settings, like > "clientCoordinatesRelativeToLayoutViewport", and make all these changes > conditional. Layout-viewport-relative coords are the future, so we should > skate etc. Agreed, that makes sense. Do you want me to do this for this patch and have the switch only switch elementFromPoint?
Tim Horton
Comment 14 2018-02-19 12:15:08 PST
Tim Horton
Comment 15 2018-02-19 13:22:17 PST
WebKit Commit Bot
Comment 16 2018-02-19 15:30:32 PST
Comment on attachment 334180 [details] Patch Clearing flags on attachment: 334180 Committed r228714: <https://trac.webkit.org/changeset/228714>
WebKit Commit Bot
Comment 17 2018-02-19 15:30:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 18 2018-02-19 15:32:33 PST
Note You need to log in before you can comment on or make changes to this bug.