Bug 182910 – REGRESSION (r219342): Touch event coordinates and elementFromPoint coordinates differ

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

REGRESSION (r219342): Touch event coordinates and elementFromPoint coordinates differ

[Tim Horton]

Created attachment 334116 [details]
Patch

[EWS Watchlist]

Comment on attachment 334116 [details]
Patch

Attachment 334116 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6559964

New failing tests:
fast/dom/elementFromPoint-scaled-scrolled.html

[EWS Watchlist]

Created attachment 334117 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 334116 [details]
Patch

Attachment 334116 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6559991

New failing tests:
fast/dom/elementFromPoint-scaled-scrolled.html

[EWS Watchlist]

Created attachment 334118 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 334116 [details]
Patch

Attachment 334116 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6560036

New failing tests:
fast/dom/elementFromPoint-scaled-scrolled.html

[EWS Watchlist]

Created attachment 334119 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 334116 [details]
Patch

Attachment 334116 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6560053

New failing tests:
fast/dom/elementFromPoint-relative-to-viewport.html
fast/dom/elementFromPoint-scaled-scrolled.html

[EWS Watchlist]

Created attachment 334120 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 334116 [details]
Patch

Attachment 334116 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6560321

New failing tests:
fast/dom/elementFromPoint-scaled-scrolled.html

[EWS Watchlist]

Created attachment 334121 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Simon Fraser (smfr)]

Comment on attachment 334116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334116&action=review

> Source/WebCore/ChangeLog:12
> +        We reverted other changes to the definition of client coordinates
> +        in r219829 due to compatibility concerns. However, we failed to revert
> +        r219342 on trunk, leaving elementFromPoint() using coordinates relative
> +        to the layout viewport.

I think the right thing to do here is to add a settings, like "clientCoordinatesRelativeToLayoutViewport", and make all these changes conditional. Layout-viewport-relative coords are the future, so we should skate etc.

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #12)
> Comment on attachment 334116 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334116&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        We reverted other changes to the definition of client coordinates
> > +        in r219829 due to compatibility concerns. However, we failed to revert
> > +        r219342 on trunk, leaving elementFromPoint() using coordinates relative
> > +        to the layout viewport.
> 
> I think the right thing to do here is to add a settings, like
> "clientCoordinatesRelativeToLayoutViewport", and make all these changes
> conditional. Layout-viewport-relative coords are the future, so we should
> skate etc.

Agreed, that makes sense. Do you want me to do this for this patch and have the switch only switch elementFromPoint?

[Tim Horton]

Created attachment 334174 [details]
Patch

[Tim Horton]

Created attachment 334180 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 334180 [details]
Patch

Clearing flags on attachment: 334180

Committed r228714: <https://trac.webkit.org/changeset/228714>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37688387>