Bug 182890 – Offlineasm/MIPS: immediates need to be within 16-bit signed values

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Guillaume Emont]

in Sequence.getModifiedListMIPS(), we allow immediate values within the range -0xffff..0xffff for immediates (addresses and other immediates), but then in Immediate.mipsOperand() and Address.mipsOperand() we raise if immediate values are not within -0x7fff..0x7fff. This is inconsistent, and broke compilation on mips since r228552 made the VM structure bigger meaning we address values with bigger offsets in llint.

[Guillaume Emont]

Created attachment 334078 [details]
Patch

Patch by Dominik Inführ for the immediate part, with addition of the immediate part by me.

[Guillaume Emont]

(In reply to Guillaume Emont from comment #1)
> Created attachment 334078 [details]
> Patch
> 
> Patch by Dominik Inführ for the immediate part, with addition of the
> immediate part by me.

I meant that Dominik did the patch for the immediate *address* part, I modified the parameters passed to riscLowerMalformedImmediates().

[WebKit Commit Bot]

Comment on attachment 334078 [details]
Patch

Rejecting attachment 334078 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334078, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://webkit-queues.webkit.org/results/6546131

[WebKit Commit Bot]

Comment on attachment 334078 [details]
Patch

Rejecting attachment 334078 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334078, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://webkit-queues.webkit.org/results/6553415

[WebKit Commit Bot]

Comment on attachment 334078 [details]
Patch

Clearing flags on attachment: 334078

Committed r228604: <https://trac.webkit.org/changeset/228604>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37652360>