Bug 182878 - [RenderTreeBuilder] Move RenderElement::addChild() to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderElement::addChild() to RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-16 09:53 PST by zalan
Modified: 2018-02-16 11:25 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.93 KB, patch)
2018-02-16 10:25 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (11.97 KB, patch)
2018-02-16 10:29 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-16 09:53:37 PST
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-16 09:53:56 PST
<rdar://problem/37608349>
Comment 2 zalan 2018-02-16 10:25:25 PST
Created attachment 334049 [details]
Patch
Comment 3 Antti Koivisto 2018-02-16 10:27:15 PST
Comment on attachment 334049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334049&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:325
>      parent.RenderElement::insertChildInternal(WTFMove(child), beforeChild);
> +    parent.RenderElement::didInsertChild(newChild, beforeChild);

RenderElement:: is probably not needed in either case.
Comment 4 zalan 2018-02-16 10:29:23 PST
Created attachment 334050 [details]
Patch
Comment 5 WebKit Commit Bot 2018-02-16 11:25:23 PST
Comment on attachment 334050 [details]
Patch

Clearing flags on attachment: 334050

Committed r228566: <https://trac.webkit.org/changeset/228566>
Comment 6 WebKit Commit Bot 2018-02-16 11:25:28 PST
All reviewed patches have been landed.  Closing bug.