RESOLVED FIXED182878
[RenderTreeBuilder] Move RenderElement::addChild() to RenderTreeBuilder 
https://bugs.webkit.org/show_bug.cgi?id=182878
Summary [RenderTreeBuilder] Move RenderElement::addChild() to RenderTreeBuilder
alan
Reported 2018-02-16 09:53:37 PST
ssia
Attachments
Patch (11.93 KB, patch)
2018-02-16 10:25 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.97 KB, patch)
2018-02-16 10:29 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-16 09:53:56 PST
<rdar://problem/37608349>
alan
Comment 2 2018-02-16 10:25:25 PST
Created attachment 334049 [details] Patch
Antti Koivisto
Comment 3 2018-02-16 10:27:15 PST
Comment on attachment 334049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334049&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:325 > parent.RenderElement::insertChildInternal(WTFMove(child), beforeChild); > + parent.RenderElement::didInsertChild(newChild, beforeChild); RenderElement:: is probably not needed in either case.
alan
Comment 4 2018-02-16 10:29:23 PST
Created attachment 334050 [details] Patch
WebKit Commit Bot
Comment 5 2018-02-16 11:25:23 PST
Comment on attachment 334050 [details] Patch Clearing flags on attachment: 334050 Committed r228566: <https://trac.webkit.org/changeset/228566>
WebKit Commit Bot
Comment 6 2018-02-16 11:25:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.