Bug 182877 - [Extra zoom mode] Form control values are stale after dismissing and representing input view controllers
Summary: [Extra zoom mode] Form control values are stale after dismissing and represen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-16 09:50 PST by Wenson Hsieh
Modified: 2018-02-17 22:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.88 KB, patch)
2018-02-17 15:35 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix non-iOS builds (21.79 KB, patch)
2018-02-17 15:45 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
ChangeLog tweaks. (22.26 KB, patch)
2018-02-17 17:35 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (22.25 KB, patch)
2018-02-17 21:14 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-02-16 09:50:34 PST 
<rdar://problem/37604395>
Comment 1 Wenson Hsieh 2018-02-17 15:35:48 PST 
Created attachment 334110 [details]
Patch
Comment 2 Wenson Hsieh 2018-02-17 15:45:55 PST 
Created attachment 334111 [details]
Fix non-iOS builds
Comment 3 Wenson Hsieh 2018-02-17 17:35:40 PST 
Created attachment 334112 [details]
ChangeLog tweaks.
Comment 4 Tim Horton 2018-02-17 20:17:04 PST 
Comment on attachment 334112 [details]
ChangeLog tweaks.

View in context: https://bugs.webkit.org/attachment.cgi?id=334112&action=review

> Source/WebKit/Shared/AssistedNodeInformation.h:117
> +    unsigned assistedNodeIdentifier { 0 };

maybe a sized type? We usually use uint64 for IDs
Comment 5 Wenson Hsieh 2018-02-17 20:58:48 PST 
Comment on attachment 334112 [details]
ChangeLog tweaks.

View in context: https://bugs.webkit.org/attachment.cgi?id=334112&action=review

Thanks for the review!

>> Source/WebKit/Shared/AssistedNodeInformation.h:117
>> +    unsigned assistedNodeIdentifier { 0 };
> 
> maybe a sized type? We usually use uint64 for IDs

Got it — changed to a `uint64_t` instead.
Comment 6 Wenson Hsieh 2018-02-17 21:14:36 PST 
Created attachment 334114 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-02-17 21:50:19 PST 
Comment on attachment 334114 [details]
Patch for landing

Clearing flags on attachment: 334114

Committed r228602: <https://trac.webkit.org/changeset/228602>