In WebResourceLoadStatisticsStore.h, MSVC doesn't seem to treat a type name which is specified by "using WTF::Vector". Its Intellisense understands the "using" definition, but the compiler doesn't. Currently there are two methods: 1) Add a new declaration to avoid this issue for MSVC. 2) Use WTF::Vector in a lambda definition
Created attachment 334039 [details] Test Patch (Work In Progress)
Created attachment 334106 [details] bz182873-1.patch
The webkitpy bot seems to have not applied this patch.
> The webkitpy bot seems to have not applied this patch. Timed out talking to Bugzilla.
Its kinda unclear on why this is needed here as its including <wtf/Vector.h> and other definitions in the file refer to Vector directly. There are a few places in that file that are using WTF::Function as well so its a bit unclear on what is going on.
Comment on attachment 334106 [details] bz182873-1.patch r=me for this workaround. Maybe this `using` does not work if we use it for lambda parameter, which lambda is defined for default parameter. I believe it is MSVC's bug.
JF, do you have any insight for this? (Is it known issue in MSVC? Or is it something wrong in our side?)
(In reply to Yusuke Suzuki from comment #7) > JF, do you have any insight for this? > (Is it known issue in MSVC? Or is it something wrong in our side?) Not known to me. Can you craft a small repro? This seems to work: https://godbolt.org/g/Tm9Yec
(In reply to JF Bastien from comment #8) > (In reply to Yusuke Suzuki from comment #7) > > JF, do you have any insight for this? > > (Is it known issue in MSVC? Or is it something wrong in our side?) > > Not known to me. Can you craft a small repro? This seems to work: > https://godbolt.org/g/Tm9Yec Yusuke Suzuki, JF Bastien, I made a simple sample. Does this example show what happen in MSVC? https://godbolt.org/g/TtDbAL
(In reply to Yousuke Kimoto from comment #9) > (In reply to JF Bastien from comment #8) > > (In reply to Yusuke Suzuki from comment #7) > > > JF, do you have any insight for this? > > > (Is it known issue in MSVC? Or is it something wrong in our side?) > > > > Not known to me. Can you craft a small repro? This seems to work: > > https://godbolt.org/g/Tm9Yec > > Yusuke Suzuki, JF Bastien, > > I made a simple sample. Does this example show what happen in MSVC? > https://godbolt.org/g/TtDbAL Ping'd a friend on the MSVC team. Confirmed to be an MSVC bug: https://twitter.com/apardoe/status/967076489085599744
(In reply to JF Bastien from comment #10) > (In reply to Yousuke Kimoto from comment #9) > > (In reply to JF Bastien from comment #8) > > > (In reply to Yusuke Suzuki from comment #7) > > > > JF, do you have any insight for this? > > > > (Is it known issue in MSVC? Or is it something wrong in our side?) > > > > > > Not known to me. Can you craft a small repro? This seems to work: > > > https://godbolt.org/g/Tm9Yec > > > > Yusuke Suzuki, JF Bastien, > > > > I made a simple sample. Does this example show what happen in MSVC? > > https://godbolt.org/g/TtDbAL > > Ping'd a friend on the MSVC team. Confirmed to be an MSVC bug: > https://twitter.com/apardoe/status/967076489085599744 Cool!
Comment on attachment 334106 [details] bz182873-1.patch Clearing flags on attachment: 334106 Committed r228951: <https://trac.webkit.org/changeset/228951>
All reviewed patches have been landed. Closing bug.
<rdar://problem/37830659>