Bug 182870 - [WinCairo] Fix compile errors of WebProcess and NetworkProcess due to no implementation for windows
Summary: [WinCairo] Fix compile errors of WebProcess and NetworkProcess due to no impl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 174003
  Show dependency tree / graph
 
Reported: 2018-02-16 05:29 PST by Yousuke Kimoto
Modified: 2018-02-21 14:19 PST (History)
10 users (show)

See Also:

Attachments
bz182870-1.patch (5.46 KB, patch)
2018-02-16 05:39 PST, Yousuke Kimoto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2018-02-16 05:29:34 PST 
Some WebKit sources of WebProcess and NetworkProcess don't have appropriate implementation for the windows port, so many compile errors occur.
This ticket solves this issue which comes from the following files:
- Source/WebKit/NetworkProcess/NetworkProcess.cpp
- Source/WebKit/WebProcess/Plugins/PluginProcessConnectionManager.cpp
- Source/WebKit/WebProcess/WebPage/WebInspector.cpp
- Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp
- Source/WebKit/WebProcess/WebProcess.cpp
Comment 1 Yousuke Kimoto 2018-02-16 05:39:58 PST 
Created attachment 334037 [details]
bz182870-1.patch
Comment 2 WebKit Commit Bot 2018-02-21 13:41:11 PST 
Comment on attachment 334037 [details]
bz182870-1.patch

Clearing flags on attachment: 334037

Committed r228893: <https://trac.webkit.org/changeset/228893>
Comment 3 WebKit Commit Bot 2018-02-21 13:41:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-02-21 13:44:24 PST 
<rdar://problem/37759301>
Comment 5 Chris Dumez 2018-02-21 14:19:47 PST 
Was there discussion on the mailing list about adding support for Windows to WebKit2?