Bug 182860 – [Cocoa] Make system-ui obey the user-installed-font policy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Make system-ui obey the user-installed-font policy

[Myles C. Maxfield]

Created attachment 333999 [details]
Patch

[EWS Watchlist]

Attachment 333999 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:21:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

<rdar://problem/36158249>

[EWS Watchlist]

Comment on attachment 333999 [details]
Patch

Attachment 333999 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6530089

New failing tests:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
fast/text/system-font-features.html
media/controls-after-reload.html

[EWS Watchlist]

Created attachment 334007 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 333999 [details]
Patch

Attachment 333999 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6530096

New failing tests:
media/video-display-toggle.html
fast/text/system-ui-chinese-bold-fallback.html
media/video-no-audio.html
fast/text/system-font-features.html
media/video-volume-slider.html

[EWS Watchlist]

Created attachment 334008 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 333999 [details]
Patch

Attachment 333999 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6530138

New failing tests:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
fast/text/system-font-features.html
media/controls-after-reload.html

[EWS Watchlist]

Created attachment 334009 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

Created attachment 334127 [details]
Patch

[EWS Watchlist]

Comment on attachment 334127 [details]
Patch

Attachment 334127 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6565867

New failing tests:
fast/text/system-ui-chinese-bold-fallback.html

[EWS Watchlist]

Created attachment 334128 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

Created attachment 334240 [details]
Patch

[Antti Koivisto]

Comment on attachment 334240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334240&action=review

r=me

> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:122
> +        auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> +        addAttributesForInstalledFonts(attributes.get(), allowUserInstalledFonts);
> +        if (CFDictionaryGetCount(attributes.get())) {
> +            auto modification = adoptCF(CTFontDescriptorCreateWithAttributes(attributes.get()));
> +            return adoptCF(CTFontCreateCopyWithAttributes(result.get(), size, nullptr, modification.get()));
> +        }

This stuff repeats several times. Could you factor it into a function?

[Myles C. Maxfield]

Created attachment 334341 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 334346 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 334346 [details]
Patch for committing

Clearing flags on attachment: 334346

Committed r228877: <https://trac.webkit.org/changeset/228877>