Bug 182859 - REGRESSION (r220112): reCAPTCHA images render off screen on Twitch.tv app Log In or Sign Up
Summary: REGRESSION (r220112): reCAPTCHA images render off screen on Twitch.tv app Log...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 184898 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-15 21:28 PST by zalan
Modified: 2018-04-27 03:27 PDT (History)
7 users (show)

See Also:

Attachments
patch (9.60 KB, patch)
2018-04-23 15:27 PDT, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (10.16 KB, patch)
2018-04-23 15:58 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-15 21:28:06 PST 
The web interface for logging in with the twitch app is unusable. The captcha they used to authenticate login renders offscreen and the button is cropped so you cannot click on it
https://itunes.apple.com/app/id460177396?mt=8
Comment 1 Radar WebKit Bug Importer 2018-02-15 21:28:39 PST 
<rdar://problem/37595065>
Comment 2 zalan 2018-02-15 21:35:11 PST 
Need to figure out how Twitch.tv depends on frame flatting sizing and why puts the image offscreen when only the first (desktop size) size is reported. see https://trac.webkit.org/changeset/220112/webkit
Comment 3 Radar WebKit Bug Importer 2018-02-15 21:35:35 PST 
<rdar://problem/37595129>
Comment 4 Antti Koivisto 2018-04-23 15:25:59 PDT 
*** Bug 184898 has been marked as a duplicate of this bug. ***
Comment 5 Antti Koivisto 2018-04-23 15:27:58 PDT 
Created attachment 338609 [details]
patch
Comment 6 Antti Koivisto 2018-04-23 15:58:13 PDT 
Created attachment 338612 [details]
patch
Comment 7 WebKit Commit Bot 2018-04-23 17:13:21 PDT 
Comment on attachment 338612 [details]
patch

Clearing flags on attachment: 338612

Committed r230933: <https://trac.webkit.org/changeset/230933>
Comment 8 WebKit Commit Bot 2018-04-23 17:13:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Darin Adler 2018-04-26 21:34:20 PDT 
I understand why we removed the fix if it’s no longer needed, but why remove the test?
Comment 10 Antti Koivisto 2018-04-27 03:27:34 PDT 
The test is for specific behavior (to break media query listener/document mutation cycle) introduced in this patch. It is not obvious to me how to modify it and to keep it still useful.