Bug 182850 - Layout Test editing/pasteboard/data-transfer-set-data-sanitizes-html-when-copying-in-null-origin.html is Timing Out
Summary: Layout Test editing/pasteboard/data-transfer-set-data-sanitizes-html-when-cop...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-15 16:33 PST by Matt Lewis
Modified: 2018-05-10 19:59 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2018-02-15 16:33:08 PST
The following layout test is failing on iOS Release WK2

editing/pasteboard/data-transfer-set-data-sanitizes-html-when-copying-in-null-origin.html

Probable cause:

The first timeout occurred with this build:
https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r227743%20(2829)/results.html
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/2829



Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fpasteboard%2Fdata-transfer-set-data-sanitizes-html-when-copying-in-null-origin.html

current build:

https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r228533%20(3228)/results.html
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/3228


Diff:
--- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/editing/pasteboard/data-transfer-set-data-sanitizes-html-when-copying-in-null-origin-expected.txt
+++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/editing/pasteboard/data-transfer-set-data-sanitizes-html-when-copying-in-null-origin-actual.txt
@@ -1,18 +1,5 @@
-This tests getData strips away secrets and dangerous code when copying inside a null origin document.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 25956)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS JSON.stringify(typesInNullOrigin) is "[\"text/html\"]"
-PASS htmlInNullOrigin.includes("secret") is false
-PASS htmlInNullOrigin.includes("dangerousCode") is false
-PASS b = (new DOMParser).parseFromString(htmlInNullOrigin, "text/html").querySelector("b"); b.textContent is "hello"
-PASS b.parentNode.textContent is "hello, world"
-PASS JSON.stringify(itemsInNullOrigin) is "[{\"kind\":\"string\",\"type\":\"text/html\"}]"
-PASS event.clipboardData.getData("text/html") is "<meta content=\"secret\"><b onmouseover=\"dangerousCode()\">hello</b><!-- secret-->, world<script>dangerousCode()</script>"
-PASS JSON.stringify(event.clipboardData.types) is "[\"text/html\"]"
-PASS JSON.stringify(Array.from(event.clipboardData.items).map((item) => ({kind: item.kind, type: item.type}))) is "[{\"kind\":\"string\",\"type\":\"text/html\"}]"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF
Comment 1 Matt Lewis 2018-02-15 16:38:49 PST
The timeouts had lessened after this final build:
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/2995


However after this revision the timeouts increased:
https://trac.webkit.org/changeset/228240/webkit
Comment 2 Wenson Hsieh 2018-02-15 23:05:07 PST
It doesn't seem like there's a dramatic increase in the number of timeouts.

I also wouldn't expect that revision to have any impact here, especially because filepaths in the pasteboard don't even play a role in this test…
Comment 3 Ryan Haddad 2018-02-19 10:50:12 PST
Skipped test on iOS Release bots in https://trac.webkit.org/r228699 because this is timing out very frequently.
Comment 4 Radar WebKit Bug Importer 2018-02-19 11:43:43 PST
<rdar://problem/37679524>
Comment 5 Ryosuke Niwa 2018-05-10 19:59:04 PDT
This doesn't seem to be happening in recent builds.