Bug 182845 – [Cocoa] Use OTF font features instead of AAT font features when possible

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Myles C. Maxfield]

Always use OTF font features instead of AAT font features

[Myles C. Maxfield]

<rdar://problem/33046942>

[Myles C. Maxfield]

Created attachment 333963 [details]
Patch

[EWS Watchlist]

Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6525379

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html

[EWS Watchlist]

Created attachment 333969 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6525492

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html
css3/font-variant-petite-caps-synthesis-coverage.html

[EWS Watchlist]

Created attachment 333973 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6525648

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html

[EWS Watchlist]

Created attachment 333975 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6526345

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html

[EWS Watchlist]

Created attachment 333978 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Aditya Keerthi]

Created attachment 408888 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 408888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408888&action=review

Very good!

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-506
> -            case kCTFontTableGPOS:
> -            case kCTFontTableGSUB:
> -                openTypeShaping = true;
> -                break;

I think we should keep this. I expect we'll need this for other things.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-522
> -    bool openTypeShaping { false };

Ditto.

[Aditya Keerthi]

Created attachment 408897 [details]
Patch for landing

[EWS]

Committed r267141: <https://trac.webkit.org/changeset/267141>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408897 [details].