Bug 182845 - [Cocoa] Use OTF font features instead of AAT font features when possible
Summary: [Cocoa] Use OTF font features instead of AAT font features when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-15 15:54 PST by Myles C. Maxfield
Modified: 2020-09-16 06:45 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.97 KB, patch)
2018-02-15 15:58 PST, Myles C. Maxfield
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.91 MB, application/zip)
2018-02-15 16:50 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (3.62 MB, application/zip)
2018-02-15 17:22 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-sierra (3.41 MB, application/zip)
2018-02-15 17:31 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.30 MB, application/zip)
2018-02-15 18:03 PST, EWS Watchlist
no flags Details
Patch (12.04 KB, patch)
2020-09-15 19:37 PDT, Aditya Keerthi
mmaxfield: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (12.08 KB, patch)
2020-09-15 21:27 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-02-15 15:54:21 PST
Always use OTF font features instead of AAT font features
Comment 1 Myles C. Maxfield 2018-02-15 15:57:58 PST
<rdar://problem/33046942>
Comment 2 Myles C. Maxfield 2018-02-15 15:58:35 PST
Created attachment 333963 [details]
Patch
Comment 3 EWS Watchlist 2018-02-15 16:50:27 PST
Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6525379

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html
Comment 4 EWS Watchlist 2018-02-15 16:50:28 PST
Created attachment 333969 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-02-15 17:22:48 PST
Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6525492

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html
css3/font-variant-petite-caps-synthesis-coverage.html
Comment 6 EWS Watchlist 2018-02-15 17:22:50 PST
Created attachment 333973 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-02-15 17:31:23 PST
Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6525648

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html
Comment 8 EWS Watchlist 2018-02-15 17:31:24 PST
Created attachment 333975 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 EWS Watchlist 2018-02-15 18:03:52 PST
Comment on attachment 333963 [details]
Patch

Attachment 333963 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6526345

New failing tests:
css3/font-feature-settings-font-face-rendering.html
css3/font-feature-settings-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-all.html
Comment 10 EWS Watchlist 2018-02-15 18:03:53 PST
Created attachment 333978 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 11 Aditya Keerthi 2020-09-15 19:37:20 PDT
Created attachment 408888 [details]
Patch
Comment 12 Myles C. Maxfield 2020-09-15 21:01:26 PDT
Comment on attachment 408888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408888&action=review

Very good!

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-506
> -            case kCTFontTableGPOS:
> -            case kCTFontTableGSUB:
> -                openTypeShaping = true;
> -                break;

I think we should keep this. I expect we'll need this for other things.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-522
> -    bool openTypeShaping { false };

Ditto.
Comment 13 Aditya Keerthi 2020-09-15 21:27:33 PDT
Created attachment 408897 [details]
Patch for landing
Comment 14 EWS 2020-09-16 06:45:57 PDT
Committed r267141: <https://trac.webkit.org/changeset/267141>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408897 [details].