Bug 182841 - Speed up dSYM generation on build.webkit.org with -gline-tables-only
Summary: Speed up dSYM generation on build.webkit.org with -gline-tables-only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-15 14:31 PST by Alexey Proskuryakov
Modified: 2018-02-15 16:07 PST (History)
7 users (show)

See Also:

Attachments
proposed patch (2.35 KB, patch)
2018-02-15 14:43 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-02-15 14:31:09 PST 
We need to produce dSYM files on CI builders to have line numbers in crash logs on testers.

On my machine, a full release build of WebKit with dSYM generation takes ~6 minutes longer than without (the time is split between slower compilation and slower dsymutil invocations). With -gline-tables-only AKA -gmlt, the cost is only 30 seconds, and the resulting dSYMs are also dramatically smaller (962 MB to 139 MB for WebCore).

I believe that we would be getting proper crash logs with -gline-tables-only too.
Comment 1 Alexey Proskuryakov 2018-02-15 14:42:47 PST 
rdar://problem/34579649
Comment 2 Alexey Proskuryakov 2018-02-15 14:43:05 PST 
Created attachment 333951 [details]
proposed patch
Comment 3 Aakash Jain 2018-02-15 15:48:32 PST 
Comment on attachment 333951 [details]
proposed patch

Seems fine to me.
Comment 4 WebKit Commit Bot 2018-02-15 16:07:28 PST 
Comment on attachment 333951 [details]
proposed patch

Clearing flags on attachment: 333951

Committed r228539: <https://trac.webkit.org/changeset/228539>
Comment 5 WebKit Commit Bot 2018-02-15 16:07:29 PST 
All reviewed patches have been landed.  Closing bug.