Bug 182831 - Finish unifying Apple Pay and Payment Request sources
Summary: Finish unifying Apple Pay and Payment Request sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-15 09:47 PST by Andy Estes
Modified: 2018-02-15 11:48 PST (History)
10 users (show)

See Also:

Attachments
Patch (11.03 KB, patch)
2018-02-15 09:49 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (12.25 KB, patch)
2018-02-15 10:07 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (17.02 KB, patch)
2018-02-15 10:47 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (17.33 KB, patch)
2018-02-15 11:12 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-02-15 09:47:34 PST 
Finish unifying Apple Pay and Payment Request sources
Comment 1 Andy Estes 2018-02-15 09:49:29 PST 
Created attachment 333907 [details]
Patch
Comment 2 Andy Estes 2018-02-15 10:07:34 PST 
Created attachment 333913 [details]
Patch
Comment 3 Keith Miller 2018-02-15 10:34:58 PST 
Comment on attachment 333913 [details]
Patch

r=me.
Comment 4 Keith Miller 2018-02-15 10:36:04 PST 
Comment on attachment 333913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333913&action=review

> Source/WebCore/SourcesCocoa.txt:-387
> -    Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp

Interesting that this was unsorted. Did you add this after my initial move to unified sources?
Comment 5 Andy Estes 2018-02-15 10:45:08 PST 
(In reply to Keith Miller from comment #4)
> Comment on attachment 333913 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=333913&action=review
> 
> > Source/WebCore/SourcesCocoa.txt:-387
> > -    Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
> 
> Interesting that this was unsorted. Did you add this after my initial move
> to unified sources?

Nope, looks like it was unsorted as of https://trac.webkit.org/r224027.

Thanks for reviewing!
Comment 6 Andy Estes 2018-02-15 10:47:17 PST 
Created attachment 333916 [details]
Patch
Comment 7 Andy Estes 2018-02-15 11:12:04 PST 
Created attachment 333918 [details]
Patch
Comment 8 WebKit Commit Bot 2018-02-15 11:47:51 PST 
Comment on attachment 333918 [details]
Patch

Clearing flags on attachment: 333918

Committed r228527: <https://trac.webkit.org/changeset/228527>
Comment 9 WebKit Commit Bot 2018-02-15 11:47:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-02-15 11:48:26 PST 
<rdar://problem/37578376>