Bug 182830 - [Modern Media Controls] REGRESSION: Inline media controls are not disabled while in fullscreen on iOS
Summary: [Modern Media Controls] REGRESSION: Inline media controls are not disabled wh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified iOS 11
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-15 05:56 PST by Antoine Quint
Modified: 2018-02-15 10:04 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.99 KB, patch)
2018-02-15 06:00 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.21 MB, application/zip)
2018-02-15 07:00 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.16 MB, application/zip)
2018-02-15 07:05 PST, EWS Watchlist 		no flags Details
Patch (2.99 KB, patch)
2018-02-15 07:27 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (3.04 KB, patch)
2018-02-15 09:27 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-15 05:56:07 PST 
When fixing https://bugs.webkit.org/show_bug.cgi?id=182668, we regressed the behaviour introduced in https://bugs.webkit.org/show_bug.cgi?id=180144.
Comment 1 Antoine Quint 2018-02-15 05:57:03 PST 
<rdar://problem/37537909>
Comment 2 Antoine Quint 2018-02-15 06:00:33 PST 
Created attachment 333895 [details]
Patch
Comment 3 EWS Watchlist 2018-02-15 07:00:17 PST 
Comment on attachment 333895 [details]
Patch

Attachment 333895 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6517149

New failing tests:
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html
Comment 4 EWS Watchlist 2018-02-15 07:00:18 PST 
Created attachment 333897 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-02-15 07:05:12 PST 
Comment on attachment 333895 [details]
Patch

Attachment 333895 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6517158

New failing tests:
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html
Comment 6 EWS Watchlist 2018-02-15 07:05:13 PST 
Created attachment 333898 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Antoine Quint 2018-02-15 07:27:24 PST 
Created attachment 333899 [details]
Patch
Comment 8 Eric Carlson 2018-02-15 09:25:45 PST 
Comment on attachment 333899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333899&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:310
> +        // Controls are always available while in fullscreen on macOS.

Nit: you might add something like this for clarity - ", and they are never available when in fullscreen on iOS".
Comment 9 Antoine Quint 2018-02-15 09:27:33 PST 
Created attachment 333905 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-02-15 10:04:00 PST 
Comment on attachment 333905 [details]
Patch for landing

Clearing flags on attachment: 333905

Committed r228519: <https://trac.webkit.org/changeset/228519>
Comment 11 WebKit Commit Bot 2018-02-15 10:04:02 PST 
All reviewed patches have been landed.  Closing bug.