Clean up HarfBuzzFaceCairo
Created attachment 333884 [details] Patch
Comment on attachment 333884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333884&action=review > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:91 > + cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get(); auto* > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:94 > + WTF::HashMap<uint32_t, uint16_t>::AddResult result = hbFontData.glyphCacheForFaceCacheEntry->add(unicode, 0); 0 -> nullptr > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:117 > + cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get(); auto* > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:135 > + cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get(); auto*
Comment on attachment 333884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333884&action=review >> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:94 >> + WTF::HashMap<uint32_t, uint16_t>::AddResult result = hbFontData.glyphCacheForFaceCacheEntry->add(unicode, 0); > > 0 -> nullptr This is an integer, uint16_t.
Created attachment 333888 [details] Patch for landing
Comment on attachment 333888 [details] Patch for landing Clearing flags on attachment: 333888 Committed r228509: <https://trac.webkit.org/changeset/228509>
All reviewed patches have been landed. Closing bug.
<rdar://problem/37564056>