Bug 182824 - Clean up HarfBuzzFaceCairo
Summary: Clean up HarfBuzzFaceCairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-15 00:22 PST by Zan Dobersek
Modified: 2018-02-15 02:13 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.05 KB, patch)
2018-02-15 00:34 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (7.01 KB, patch)
2018-02-15 02:05 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-02-15 00:22:20 PST
Clean up HarfBuzzFaceCairo
Comment 1 Zan Dobersek 2018-02-15 00:34:49 PST
Created attachment 333884 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-02-15 01:48:31 PST
Comment on attachment 333884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333884&action=review

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:91
> +    cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get();

auto*

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:94
> +    WTF::HashMap<uint32_t, uint16_t>::AddResult result = hbFontData.glyphCacheForFaceCacheEntry->add(unicode, 0);

0 -> nullptr

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:117
> +    cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get();

auto*

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:135
> +    cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get();

auto*
Comment 3 Zan Dobersek 2018-02-15 02:05:05 PST
Comment on attachment 333884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333884&action=review

>> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:94
>> +    WTF::HashMap<uint32_t, uint16_t>::AddResult result = hbFontData.glyphCacheForFaceCacheEntry->add(unicode, 0);
> 
> 0 -> nullptr

This is an integer, uint16_t.
Comment 4 Zan Dobersek 2018-02-15 02:05:33 PST
Created attachment 333888 [details]
Patch for landing
Comment 5 Zan Dobersek 2018-02-15 02:12:41 PST
Comment on attachment 333888 [details]
Patch for landing

Clearing flags on attachment: 333888

Committed r228509: <https://trac.webkit.org/changeset/228509>
Comment 6 Zan Dobersek 2018-02-15 02:12:45 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-02-15 02:13:19 PST
<rdar://problem/37564056>