RESOLVED FIXED 182824
Clean up HarfBuzzFaceCairo 
https://bugs.webkit.org/show_bug.cgi?id=182824
Summary Clean up HarfBuzzFaceCairo
Zan Dobersek
Reported 2018-02-15 00:22:20 PST
Clean up HarfBuzzFaceCairo
Attachments
Patch (7.05 KB, patch)
2018-02-15 00:34 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.01 KB, patch)
2018-02-15 02:05 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-02-15 00:34:49 PST
Created attachment 333884 [details] Patch
Carlos Garcia Campos
Comment 2 2018-02-15 01:48:31 PST
Comment on attachment 333884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333884&action=review > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:91 > + cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get(); auto* > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:94 > + WTF::HashMap<uint32_t, uint16_t>::AddResult result = hbFontData.glyphCacheForFaceCacheEntry->add(unicode, 0); 0 -> nullptr > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:117 > + cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get(); auto* > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:135 > + cairo_scaled_font_t* scaledFont = hbFontData.cairoScaledFont.get(); auto*
Zan Dobersek
Comment 3 2018-02-15 02:05:05 PST
Comment on attachment 333884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333884&action=review >> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:94 >> + WTF::HashMap<uint32_t, uint16_t>::AddResult result = hbFontData.glyphCacheForFaceCacheEntry->add(unicode, 0); > > 0 -> nullptr This is an integer, uint16_t.
Zan Dobersek
Comment 4 2018-02-15 02:05:33 PST
Created attachment 333888 [details] Patch for landing
Zan Dobersek
Comment 5 2018-02-15 02:12:41 PST
Comment on attachment 333888 [details] Patch for landing Clearing flags on attachment: 333888 Committed r228509: <https://trac.webkit.org/changeset/228509>
Zan Dobersek
Comment 6 2018-02-15 02:12:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-02-15 02:13:19 PST
<rdar://problem/37564056>
Note You need to log in before you can comment on or make changes to this bug.