Bug 182823 - HarfBuzzFace should not be ref-counted
Summary: HarfBuzzFace should not be ref-counted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-14 23:53 PST by Zan Dobersek
Modified: 2018-02-15 02:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2018-02-15 00:10 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (5.20 KB, patch)
2018-02-15 02:00 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-02-14 23:53:57 PST 
HarfBuzzFace should not be ref-counted
Comment 1 Zan Dobersek 2018-02-15 00:10:03 PST 
Created attachment 333883 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-02-15 01:45:26 PST 
Comment on attachment 333883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333883&action=review

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h:44
> +class HarfBuzzFace {
>  public:

WTF_MAKE_FAST_ALLOCATED;
Comment 3 Zan Dobersek 2018-02-15 02:00:47 PST 
Created attachment 333887 [details]
Patch for landing
Comment 4 Zan Dobersek 2018-02-15 02:10:24 PST 
Comment on attachment 333887 [details]
Patch for landing

Clearing flags on attachment: 333887

Committed r228507: <https://trac.webkit.org/changeset/228507>
Comment 5 Zan Dobersek 2018-02-15 02:10:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-15 02:11:20 PST 
<rdar://problem/37564034>