Bug 182801 - Setting a VMTrap shouldn't look at topCallFrame since that may imply we're in C code and holding the malloc lock
Summary: Setting a VMTrap shouldn't look at topCallFrame since that may imply we're in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-14 11:32 PST by Saam Barati
Modified: 2018-02-14 15:26 PST (History)
13 users (show)

See Also:


Attachments
patch (7.90 KB, patch)
2018-02-14 12:23 PST, Saam Barati
keith_miller: review+
Details | Formatted Diff | Diff
patch for landing (6.61 KB, patch)
2018-02-14 13:31 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-02-14 11:32:44 PST
...
Comment 1 Saam Barati 2018-02-14 12:23:22 PST
Created attachment 333828 [details]
patch
Comment 2 Keith Miller 2018-02-14 12:26:10 PST
Comment on attachment 333828 [details]
patch

r=me.
Comment 3 Saam Barati 2018-02-14 13:25:33 PST
Comment on attachment 333828 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333828&action=review

> Tools/Scripts/run-jsc-stress-tests:725
> +            runFTLEagerWatchdog if rand(100) < 15

Gonna do this in a follow up patch. It requires some other changes.
Comment 4 Saam Barati 2018-02-14 13:31:10 PST
Created attachment 333834 [details]
patch for landing
Comment 5 Saam Barati 2018-02-14 15:04:18 PST
<rdar://problem/37550069>
Comment 6 WebKit Commit Bot 2018-02-14 15:25:58 PST
Comment on attachment 333834 [details]
patch for landing

Clearing flags on attachment: 333834

Committed r228488: <https://trac.webkit.org/changeset/228488>
Comment 7 WebKit Commit Bot 2018-02-14 15:26:00 PST
All reviewed patches have been landed.  Closing bug.