Bug 182799 - WebCore headers should not include config.h or PlatformExportMacros.h
Summary: WebCore headers should not include config.h or PlatformExportMacros.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Keywords: InRadar
Depends on:
Reported: 2018-02-14 11:22 PST by Don Olmstead
Modified: 2018-02-14 13:24 PST (History)
7 users (show)

See Also:

Patch (10.75 KB, patch)
2018-02-14 11:25 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-02-14 11:22:11 PST
Currently in WebCore a number of headers include PlatformExportMacros.h. This should only be included within config.h

One file actually includes config.h directly which is a private header.

These cases should be removed.
Comment 1 Don Olmstead 2018-02-14 11:25:37 PST
Created attachment 333821 [details]
Comment 2 WebKit Commit Bot 2018-02-14 13:23:08 PST
Comment on attachment 333821 [details]

Clearing flags on attachment: 333821

Committed r228483: <https://trac.webkit.org/changeset/228483>
Comment 3 WebKit Commit Bot 2018-02-14 13:23:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-02-14 13:24:32 PST