Bug 182796 - EventDispatcher::wheelEvent uses a wrong enum values in switch
Summary: EventDispatcher::wheelEvent uses a wrong enum values in switch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-14 10:38 PST by Ryosuke Niwa
Modified: 2018-02-14 11:08 PST (History)
4 users (show)

See Also:

Attachments
Fixes the bug (1.56 KB, patch)
2018-02-14 10:40 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (1.56 KB, patch)
2018-02-14 10:45 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-02-14 10:38:14 PST 
EventDispatcher::wheelEvent is using PlatformWheelEventPhaseBegan and PlatformWheelEventPhaseEnded
but the enum type of wheelEvent.phase() is WebWheelEvent::Phase.
Comment 1 Ryosuke Niwa 2018-02-14 10:40:33 PST 
Created attachment 333815 [details]
Fixes the bug
Comment 2 EWS Watchlist 2018-02-14 10:41:59 PST 
Attachment 333815 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2018-02-14 10:45:26 PST 
Created attachment 333816 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-02-14 11:07:38 PST 
Comment on attachment 333816 [details]
Patch for landing

Clearing flags on attachment: 333816

Committed r228473: <https://trac.webkit.org/changeset/228473>
Comment 5 WebKit Commit Bot 2018-02-14 11:07:40 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-14 11:08:29 PST 
<rdar://problem/37541231>