Bug 182787 - Remove line without any effect.
Summary: Remove line without any effect.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-14 03:54 PST by Dominik Inführ
Modified: 2018-05-18 02:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.18 KB, patch)
2018-02-14 03:54 PST, Dominik Inführ
no flags Details | Formatted Diff | Diff
Patch v2 (1.18 KB, patch)
2018-02-21 05:58 PST, Dominik Inführ
mcatanzaro: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-02-14 03:54:07 PST
Created attachment 333784 [details]
Patch

The following line was supposed to skip the test on ARM-architectures. The condition never evaluates to true though, so the test isn't skipped. Remove the line since the test passes just fine on my Raspberry Pi 2.
Comment 1 Dominik Inführ 2018-02-21 05:58:15 PST
Created attachment 334368 [details]
Patch v2
Comment 2 WebKit Commit Bot 2018-05-17 12:32:37 PDT
Comment on attachment 334368 [details]
Patch v2

Rejecting attachment 334368 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 334368, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file JSTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file JSTests/stress/new-largeish-contiguous-array-with-size.js
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file JSTests/stress/new-largeish-contiguous-array-with-size.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Catanzaro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7713406