Bug 182783 - [FTL] Support ArrayPop for ArrayStorage
Summary: [FTL] Support ArrayPop for ArrayStorage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-14 03:02 PST by Yusuke Suzuki
Modified: 2018-02-19 20:34 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.37 KB, patch)
2018-02-14 03:03 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (7.90 KB, patch)
2018-02-14 03:08 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-02-14 03:02:39 PST 
[FTL] Support ArrayPop for ArrayStorage
Comment 1 Yusuke Suzuki 2018-02-14 03:03:42 PST 
Created attachment 333778 [details]
Patch
Comment 2 Yusuke Suzuki 2018-02-14 03:08:29 PST 
Created attachment 333779 [details]
Patch
Comment 3 Saam Barati 2018-02-19 18:55:53 PST 
Comment on attachment 333779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333779&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4768
> +                m_out.aboveOrEqual(newLength, m_out.load32(storage, m_heaps.Butterfly_vectorLength)), usually(slowCase), usually(popCheckCase));

You do 'usually' twice here. You probably want 'rarely(slowCase)'
Comment 4 Yusuke Suzuki 2018-02-19 20:02:14 PST 
Comment on attachment 333779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333779&action=review

Thanks!

>> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4768
>> +                m_out.aboveOrEqual(newLength, m_out.load32(storage, m_heaps.Butterfly_vectorLength)), usually(slowCase), usually(popCheckCase));
> 
> You do 'usually' twice here. You probably want 'rarely(slowCase)'

Right, I'll change this to `rarely(slowCase)`.
Comment 5 Yusuke Suzuki 2018-02-19 20:33:39 PST 
Committed r228727: <https://trac.webkit.org/changeset/228727>
Comment 6 Radar WebKit Bug Importer 2018-02-19 20:34:25 PST 
<rdar://problem/37696362>