[FTL] Support ArrayPop for ArrayStorage
Created attachment 333778 [details] Patch
Created attachment 333779 [details] Patch
Comment on attachment 333779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333779&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4768 > + m_out.aboveOrEqual(newLength, m_out.load32(storage, m_heaps.Butterfly_vectorLength)), usually(slowCase), usually(popCheckCase)); You do 'usually' twice here. You probably want 'rarely(slowCase)'
Comment on attachment 333779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333779&action=review Thanks! >> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4768 >> + m_out.aboveOrEqual(newLength, m_out.load32(storage, m_heaps.Butterfly_vectorLength)), usually(slowCase), usually(popCheckCase)); > > You do 'usually' twice here. You probably want 'rarely(slowCase)' Right, I'll change this to `rarely(slowCase)`.
Committed r228727: <https://trac.webkit.org/changeset/228727>
<rdar://problem/37696362>