Bug 182751 – [Curl] Curl Cookie Database File should be configurable using NetworkProcessCreationParameters

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Christopher Reid]

In preparation for WinCairo WebKit2, the curl should follow the other ports and allow the cookie file to be configurable through the network process creation parameters.

[Christopher Reid]

Created attachment 333746 [details]
patch

[EWS Watchlist]

Attachment 333746 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:50:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Christopher Reid]

Created attachment 333748 [details]
patch

Fixing style issues

[youenn fablet]

Comment on attachment 333748 [details]
patch

I do not see anything wrong there related to the 'OWNER' side.
I am not very familiar with CURL, it would be good if somebody more familiar could take an additional look.

View in context: https://bugs.webkit.org/attachment.cgi?id=333748&action=review

> Source/WebKit/ChangeLog:10
> +        This is parameter is not used yet, it is added to prepare for WinCairo WebKit support.

s/This is/This/

[Chris Dumez]

Was there discussion on the mailing list about adding support for Windows to WebKit2?

[Christopher Reid]

Created attachment 334413 [details]
Patch for landing

[Christopher Reid]

(In reply to Chris Dumez from comment #5)
> Was there discussion on the mailing list about adding support for Windows to
> WebKit2?

I don't think there was too much discussion about adding WebKit 2 support for WinCairo on the mailing list yet. Don has mentioned that was something we were working in one of our updates here: https://lists.webkit.org/pipermail/webkit-dev/2017-November/029783.html. We are very much interested in working towards WebKit2 support including getting WebKit2 WinCairo buildbots going. Let us know if you would like to see the discussion opened up on the mailing list some more.

[Don Olmstead]

Its actually been longer than that https://lists.webkit.org/pipermail/webkit-dev/2017-August/029329.html

[WebKit Commit Bot]

Comment on attachment 334413 [details]
Patch for landing

Clearing flags on attachment: 334413

Committed r228905: <https://trac.webkit.org/changeset/228905>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37765140>