Bug 182742 - Web Automation: don't return an error if resizing/moving a window has no effect
Summary: Web Automation: don't return an error if resizing/moving a window has no effect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-13 13:07 PST by BJ Burg
Modified: 2018-02-13 14:37 PST (History)
6 users (show)

See Also:


Attachments
Proposed Fix (3.06 KB, patch)
2018-02-13 13:52 PST, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-02-13 13:07:21 PST
The specification has no such demands, and it just causes tests to fail unnecessarily. Remove the error case.
Comment 1 BJ Burg 2018-02-13 13:52:59 PST
Created attachment 333721 [details]
Proposed Fix
Comment 2 Tim Horton 2018-02-13 13:59:16 PST
Comment on attachment 333721 [details]
Proposed Fix

What's the testing story? I would have expected the original code to come with a test, but I don't see you removing one?
Comment 3 BJ Burg 2018-02-13 14:21:14 PST
(In reply to Tim Horton from comment #2)
> Comment on attachment 333721 [details]
> Proposed Fix
> 
> What's the testing story? I would have expected the original code to come
> with a test, but I don't see you removing one?

The Set Window Rect W3C endpoint for safaridriver is blocked by other reviews, but once it's hooked up, I hit this in my branch while running conformance tests. It expects setting window rect to be idempotent without error if you get the window frame then set the window frame to the same rect.

https://github.com/w3c/web-platform-tests/blob/master/webdriver/tests/set_window_rect.py#L261
Comment 4 WebKit Commit Bot 2018-02-13 14:36:20 PST
Comment on attachment 333721 [details]
Proposed Fix

Clearing flags on attachment: 333721

Committed r228434: <https://trac.webkit.org/changeset/228434>
Comment 5 WebKit Commit Bot 2018-02-13 14:36:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-13 14:37:19 PST
<rdar://problem/37513710>