Bug 182740 - [GTK][WPE] Fullscreen video is broken
Summary: [GTK][WPE] Fullscreen video is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
: 179721 182109 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-13 12:26 PST by Michael Catanzaro
Modified: 2018-02-18 23:49 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2018-02-16 01:18 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2018-02-16 01:19 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.03 KB, patch)
2018-02-16 02:42 PST, Philippe Normand 		mcatanzaro: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-02-13 12:26:58 PST 
Load https://bug791090.bugzilla-attachments.gnome.org/attachment.cgi?id=368326

Try to click the fullscreen icon, or right click and "switch video to fullscreen". Nothing happens. This is using 2.19.90.
Comment 1 Philippe Normand 2018-02-15 07:39:04 PST 
ENABLE(VIDEO_USES_ELEMENT_FULLSCREEN) is not enabled and should be enabled for the GTK and WPE ports. What's the best way to enable it?
Comment 2 Michael Catanzaro 2018-02-15 10:40:31 PST 
Add it to WebKitFeatures.cmake, default to ON, and add a WEBKIT_OPTION_DEPEND to make it depend on ENABLE_VIDEO.
Comment 3 Philippe Normand 2018-02-16 01:18:46 PST 
Created attachment 334022 [details]
Patch
Comment 4 Philippe Normand 2018-02-16 01:19:30 PST 
Created attachment 334023 [details]
Patch
Comment 5 Philippe Normand 2018-02-16 02:42:05 PST 
Created attachment 334029 [details]
Patch
Comment 6 Michael Catanzaro 2018-02-16 09:25:37 PST 
Comment on attachment 334029 [details]
Patch

My question is: for how long has this been broken? Surely it used to work...?
Comment 7 Philippe Normand 2018-02-16 14:45:33 PST 
It's been broken for 3 months. See also https://bugs.webkit.org/show_bug.cgi?id=179721
Comment 8 Philippe Normand 2018-02-18 23:44:01 PST 
*** Bug 182109 has been marked as a duplicate of this bug. ***
Comment 9 Philippe Normand 2018-02-18 23:44:12 PST 
*** Bug 179721 has been marked as a duplicate of this bug. ***
Comment 10 Philippe Normand 2018-02-18 23:48:04 PST 
https://trac.webkit.org/changeset/228608/webkit
Comment 11 Radar WebKit Bug Importer 2018-02-18 23:49:22 PST 
<rdar://problem/37662566>