Bug 182721 - Web Inspector: TabBar redesign: only show allowed tabs in the available tabs context menu
Summary: Web Inspector: TabBar redesign: only show allowed tabs in the available tabs ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-12 16:44 PST by Matt Baker
Modified: 2018-02-14 12:17 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.71 KB, patch)
2018-02-12 16:49 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-02-12 16:44:37 PST 
Summary:
Only show allowed tabs in the available tabs context menu.

Steps to Reproduce:
1. Open Inspector
2. Settings > Experimental
3. Confirm "Enable Layers Tab" is disabled
4. Right-click anywhere in the tab bar
  => Context menu contains unchecked "Layers" item

Adding the tab and reloading the Inspector will cause an error, since the LayersTabContentView can't be added unless the experimental setting is enabled.
Comment 1 Radar WebKit Bug Importer 2018-02-12 16:45:04 PST 
<rdar://problem/37479019>
Comment 2 Radar WebKit Bug Importer 2018-02-12 16:45:06 PST 
<rdar://problem/37479023>
Comment 3 Matt Baker 2018-02-12 16:49:26 PST 
Created attachment 333647 [details]
Patch
Comment 4 WebKit Commit Bot 2018-02-14 12:17:34 PST 
Comment on attachment 333647 [details]
Patch

Clearing flags on attachment: 333647

Committed r228479: <https://trac.webkit.org/changeset/228479>
Comment 5 WebKit Commit Bot 2018-02-14 12:17:36 PST 
All reviewed patches have been landed.  Closing bug.