Bug 182718 – Set the appropriate AutoFill context for suggested passwords

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

Provide ability to set the appropriate AutoFill context for AutoFill password suggestion.

<rdar://problem/36326863>

Created attachment 333642 [details]
Patch

Created attachment 333856 [details]
Patch

[Tim Horton]

Comment on attachment 333856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333856&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKFormInputSession.h:47
> +@property (nonatomic, readonly) BOOL requiresStrongPasswordAssistance WK_API_AVAILABLE(ios(12.0));

This should use WK_IOS_TBD or whatever.

I will update the patch with WK_IOS_TBD.

Created attachment 333903 [details]
Patch

[Wenson Hsieh]

Comment on attachment 333903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333903&action=review

r=me (I'm not a WebKit2 owner though, so a WebKit2 owner should r+ if looks OK)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4035
> +        _firstResponderRequiresStrongPasswordAssistance = [inputDelegate _webView:_webView focusRequiresStrongPasswordAssistance:focusedElementInfo.get()];

Nit - it's a tiny bit weird for the thing that "requires strong password assistance" to be different between the ivar and the delegate method (firstResponder(…) vs. focus(…)). Could we choose one to make it consistent?

[Tim Horton]

Comment on attachment 333903 [details]
Patch

Agree with Wenson’s comment about the oddly slightly different names.

I will use 'focus' terminology.

Thanks!

Created attachment 334061 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 334061 [details]
Patch

Clearing flags on attachment: 334061

Committed r228605: <https://trac.webkit.org/changeset/228605>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.