Bug 182716 - Unify UserAgent into WebCore/platform.
Summary: Unify UserAgent into WebCore/platform.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-12 16:03 PST by Ross Kirsling
Modified: 2018-02-12 18:27 PST (History)
6 users (show)

See Also:

Attachments
Patch (35.51 KB, patch)
2018-02-12 16:44 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-02-12 16:03:23 PST 
Unify UserAgent into WebCore/platform (thereby addressing the FIXME leftover by https://bugs.webkit.org/show_bug.cgi?id=163508#c5).
Comment 1 Ross Kirsling 2018-02-12 16:44:12 PST 
Created attachment 333644 [details]
Patch
Comment 2 Michael Catanzaro 2018-02-12 17:20:55 PST 
Comment on attachment 333644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333644&action=review

Nice, thanks.

> Source/WebCore/platform/UserAgent.h:-32
> -#if PLATFORM(COCOA)
> -// FIXME: Remove Source/WebCore/page/cocoa/UserAgent.h
> -#include_next "UserAgent.h"
> -#else

Wow, I forgot that #include_next existed. That was awful.
Comment 3 WebKit Commit Bot 2018-02-12 18:26:22 PST 
Comment on attachment 333644 [details]
Patch

Clearing flags on attachment: 333644

Committed r228413: <https://trac.webkit.org/changeset/228413>
Comment 4 WebKit Commit Bot 2018-02-12 18:26:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-12 18:27:36 PST 
<rdar://problem/37482805>