Bug 182712 - [Web Animations] Support the copy constructors for KeyframeEffectReadOnly and KeyframeEffect
Summary: [Web Animations] Support the copy constructors for KeyframeEffectReadOnly and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-12 15:12 PST by Antoine Quint
Modified: 2018-02-12 17:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (17.11 KB, patch)
2018-02-12 15:16 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (11.50 MB, application/zip)
2018-02-12 16:55 PST, EWS Watchlist 		no flags Details
Patch for landing (17.04 KB, patch)
2018-02-12 17:11 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-12 15:12:07 PST 
[Web Animations] Support the copy constructors for KeyframeEffectReadOnly and KeyframeEffect
Comment 1 Antoine Quint 2018-02-12 15:16:01 PST 
Created attachment 333636 [details]
Patch
Comment 2 EWS Watchlist 2018-02-12 16:55:49 PST 
Comment on attachment 333636 [details]
Patch

Attachment 333636 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6473515

New failing tests:
http/tests/preload/onerror_event.html
Comment 3 EWS Watchlist 2018-02-12 16:55:59 PST 
Created attachment 333648 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Dean Jackson 2018-02-12 17:02:15 PST 
Comment on attachment 333636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333636&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:49
> +    UNUSED_PARAM(state);

Just remove the "state" part of the parameter.

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:404
> +    UNUSED_PARAM(state);

Ditto.
Comment 5 Antoine Quint 2018-02-12 17:11:47 PST 
Created attachment 333649 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-02-12 17:28:32 PST 
Comment on attachment 333649 [details]
Patch for landing

Clearing flags on attachment: 333649

Committed r228412: <https://trac.webkit.org/changeset/228412>
Comment 7 WebKit Commit Bot 2018-02-12 17:28:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-02-12 17:30:10 PST 
<rdar://problem/37481146>