Bug 182711 - Use GetArrayMask in the DFG
Summary: Use GetArrayMask in the DFG
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-12 15:11 PST by Saam Barati
Modified: 2018-05-10 11:21 PDT (History)
12 users (show)

See Also:

Attachments
WIP (16.62 KB, patch)
2018-02-12 18:45 PST, Saam Barati 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews201 for win-future (1.68 MB, application/zip)
2018-02-12 20:10 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-02-12 15:11:51 PST 
...
Comment 1 Saam Barati 2018-02-12 18:24:20 PST 
I think this will only be profitable if we end up CSEing it. If not, it'll end up using an extra register on x86, since we're losing the address-based and32. Anyways, will test perf.
Comment 2 Saam Barati 2018-02-12 18:45:48 PST 
Created attachment 333656 [details]
WIP
Comment 3 EWS Watchlist 2018-02-12 20:10:38 PST 
Comment on attachment 333656 [details]
WIP

Attachment 333656 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6476757

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-02-12 20:10:41 PST 
Created attachment 333666 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Saam Barati 2018-05-10 11:21:25 PDT 
We're not doing index masking anymore