RESOLVED FIXED 182684
[css-grid] Apply automatic minimum size clamping to spanning items too 
https://bugs.webkit.org/show_bug.cgi?id=182684
Summary [css-grid] Apply automatic minimum size clamping to spanning items too
Manuel Rego Casasnovas
Reported 2018-02-11 22:56:42 PST
[css-grid] Apply automatic minimum size clamping to spanning items too
Attachments
Patch (79.98 KB, patch)
2018-02-11 22:58 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (79.97 KB, patch)
2018-02-12 00:42 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch for landing (79.94 KB, patch)
2018-02-19 03:34 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2018-02-11 22:58:20 PST
Created attachment 333580 [details] Patch
Manuel Rego Casasnovas
Comment 2 2018-02-12 00:42:21 PST
Created attachment 333585 [details] Patch
Javier Fernandez
Comment 3 2018-02-19 03:26:37 PST
Comment on attachment 333585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333585&action=review > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:751 > + const GridSpan& span = m_algorithm.grid().gridItemSpan(child, direction()); We can use 'auto' here too. Actually, it seems we only use the variable in the loop definition; we could just call gridItemSpan there and avoid this variable.
Manuel Rego Casasnovas
Comment 4 2018-02-19 03:34:24 PST
Created attachment 334148 [details] Patch for landing
Manuel Rego Casasnovas
Comment 5 2018-02-19 03:34:55 PST
Comment on attachment 333585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333585&action=review Thanks for the review >> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:751 >> + const GridSpan& span = m_algorithm.grid().gridItemSpan(child, direction()); > > We can use 'auto' here too. > Actually, it seems we only use the variable in the loop definition; we could just call gridItemSpan there and avoid this variable. True, I've moved the call to the for loop. Nice catch.
WebKit Commit Bot
Comment 6 2018-02-19 04:10:21 PST
Comment on attachment 334148 [details] Patch for landing Clearing flags on attachment: 334148 Committed r228661: <https://trac.webkit.org/changeset/228661>
WebKit Commit Bot
Comment 7 2018-02-19 04:10:22 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-02-19 04:11:23 PST
<rdar://problem/37666607>
Note You need to log in before you can comment on or make changes to this bug.