WinCairo WebKit requires WebKIt2_C.h to build TestWebKit.
Created attachment 333579 [details] Patch
Since WebKit2_C is needed to be included in case of the wincairo webkit build, an option to specify the build mode is required. I'll fix the issue.
Comment on attachment 333579 [details] Patch Attachment 333579 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6461547 New failing tests: http/tests/preload/onerror_event.html
Created attachment 333584 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 333683 [details] bz182682-2.patch
Comment on attachment 333683 [details] bz182682-2.patch View in context: https://bugs.webkit.org/attachment.cgi?id=333683&action=review > Tools/TestWebKitAPI/config.h:64 > +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) Why doesn't `PLATFORM(WIN_CAIRO)` work?
(In reply to Yusuke Suzuki from comment #6) > > Tools/TestWebKitAPI/config.h:64 > > +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) > > Why doesn't `PLATFORM(WIN_CAIRO)` work? "PLATFORM(WIN_CAIRO)" is used by both WinCairo WebKitLegacy and WebKit but WinCairo WebKit is an optional build mode for now. In addition, the WinCairo's EWS configuration is dedicated for WebKitLegacy. The EWS will fail during building TestWebKitAPI due to including "WebKIt/WebKit2_C.h" which cannot be referred in the configuration. To avoid such failure, "WebKit/WebKit2_C.h" should be included only for WinCairo WebKit. That is why "BUILDING_WIN_CAIRO_WEBKIT" is newly defined. We need the definition until when we establish to build WinCairo WebKit stably.
Comment on attachment 333683 [details] bz182682-2.patch View in context: https://bugs.webkit.org/attachment.cgi?id=333683&action=review >> Tools/TestWebKitAPI/config.h:64 >> +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) > > Why doesn't `PLATFORM(WIN_CAIRO)` work? OK, so please note that we will remove `BUILDING_WIN_CAIRO_WEBKIT` once WinCairo WebKit is done (and non optional).
(In reply to Yusuke Suzuki from comment #8) > >> Tools/TestWebKitAPI/config.h:64 > >> +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) > > > > Why doesn't `PLATFORM(WIN_CAIRO)` work? > > OK, so please note that we will remove `BUILDING_WIN_CAIRO_WEBKIT` once > WinCairo WebKit is done (and non optional). Sure, we'll do that. Thank you for your review!
Comment on attachment 333683 [details] bz182682-2.patch Clearing flags on attachment: 333683 Committed r229029: <https://trac.webkit.org/changeset/229029>
All reviewed patches have been landed. Closing bug.
<rdar://problem/37908607>