Bug 182677 - Ignore order when parsing inset and color for box-shadow
Summary: Ignore order when parsing inset and color for box-shadow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-11 14:42 PST by Chris Nardi
Modified: 2020-11-03 21:00 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.26 KB, patch)
2018-02-11 14:44 PST, Chris Nardi 		no flags Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2020-11-01 22:01 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (15.73 KB, patch)
2020-11-02 10:11 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Nardi 2018-02-11 14:42:38 PST 
Ignore order when parsing inset and color for box-shadow
Comment 1 Chris Nardi 2018-02-11 14:44:21 PST 
Created attachment 333573 [details]
Patch
Comment 2 Chris Nardi 2018-02-11 16:29:55 PST 
Looks like this is only a part of the bug; it appears WebKit has some other issue with the inset keyword (see https://w3c-test.org/css/css-backgrounds/box-shadow-syntax-001.xht).
Comment 3 Chris Nardi 2018-02-11 16:30:18 PST 
(this probably isn't ready for review yet as such as the test case still fails)
Comment 4 Tyler Wilcock 2020-11-01 22:01:18 PST 
Created attachment 412882 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-11-02 08:12:12 PST 
Comment on attachment 412882 [details]
Patch

I'd like to see some more testing of the invalid cases (e.g. two colors or styles per shadow etc).
Comment 6 Tyler Wilcock 2020-11-02 10:11:12 PST 
Created attachment 412938 [details]
Patch
Comment 7 Tyler Wilcock 2020-11-02 11:18:57 PST 
OK Simon, I added tests for these invalid cases.  Added r? and cq?.
Comment 8 EWS 2020-11-03 20:59:07 PST 
Committed r269354: <https://trac.webkit.org/changeset/269354>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412938 [details].
Comment 9 Radar WebKit Bug Importer 2020-11-03 21:00:27 PST 
<rdar://problem/71022889>