Bug 182674 - Add support for configuring WebsiteDatastore service worker and cache storage path
Summary: Add support for configuring WebsiteDatastore service worker and cache storage...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-11 09:47 PST by youenn fablet
Modified: 2018-02-14 13:23 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.93 KB, patch)
2018-02-11 09:51 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-02-11 09:47:59 PST 
Add support for configuring WebsiteDatastore service worker and cache storage path
Comment 1 youenn fablet 2018-02-11 09:51:15 PST 
Created attachment 333569 [details]
Patch
Comment 2 WebKit Commit Bot 2018-02-13 16:08:45 PST 
Comment on attachment 333569 [details]
Patch

Clearing flags on attachment: 333569

Committed r228442: <https://trac.webkit.org/changeset/228442>
Comment 3 WebKit Commit Bot 2018-02-13 16:08:46 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-02-13 16:09:47 PST 
<rdar://problem/37517744>
Comment 5 Alexey Proskuryakov 2018-02-14 13:23:18 PST 
Comment on attachment 333569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333569&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:109
> +    return _cacheStorageDirectoryURL.get();

Is it OK to just return internal objects here, or do we need copy+autorelease?