Bug 182667 – Web Inspector: Canvas tab: tree selection abruptly changes when selecting a recording frame

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Tree selection abruptly changes when selecting a recording frame.

Steps to Reproduce:
1. Goto https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_animations
2. Record any canvas
3. In the sidebar, select 'Frame 1'
  => Tree selection jumps to the last action in the frame

[Radar WebKit Bug Importer]

<rdar://problem/37412639>

[Matt Baker]

Created attachment 333545 [details]
Patch

[Matt Baker]

Created attachment 333548 [details]
Patch

[Devin Rousso]

Comment on attachment 333548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333548&action=review

r=me.  This feels much more smooth.  I still think that we shouldn't auto-select a recording when viewing a Canvas, but we can discuss that before doing anything.

> Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css:71
> +.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.folder-icon > .status {
> +    line-height: 16px;
> +}

This rule already exists below.

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.css:247
> +.tree-outline:not(.large):matches(:focus, .force-focus) .item.selected .status .indeterminate-progress-spinner {
> +    filter: invert();
> +}

Nice!

[Matt Baker]

Created attachment 333552 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 333552 [details]
Patch for landing

Clearing flags on attachment: 333552

Committed r228362: <https://trac.webkit.org/changeset/228362>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.