WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182662
[RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=182662
Summary
[RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder
zalan
Reported
2018-02-09 15:57:41 PST
ssia
Attachments
Patch
(19.71 KB, patch)
2018-02-09 16:14 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(19.60 KB, patch)
2018-02-09 19:42 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(19.60 KB, patch)
2018-02-09 20:16 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(19.60 KB, patch)
2018-02-10 06:57 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-02-09 15:58:01 PST
<
rdar://problem/37408571
>
zalan
Comment 2
2018-02-09 16:14:54 PST
Created
attachment 333531
[details]
Patch
Simon Fraser (smfr)
Comment 3
2018-02-09 16:16:52 PST
Comment on
attachment 333531
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=333531&action=review
> Source/WebCore/rendering/RenderBlock.cpp:499 > + return builder.takenChildFromRenderBlock(*this, oldChild);
takeChild
> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:473 > +RenderPtr<RenderObject> RenderTreeBuilder::takenChildFromRenderBlock(RenderBlock& parent, RenderObject& oldChild)
taken
zalan
Comment 4
2018-02-09 19:42:53 PST
Created
attachment 333549
[details]
Patch
zalan
Comment 5
2018-02-09 20:16:51 PST
Created
attachment 333551
[details]
Patch
WebKit Commit Bot
Comment 6
2018-02-10 06:52:40 PST
Comment on
attachment 333551
[details]
Patch Rejecting
attachment 333551
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 333551, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output:
http://webkit-queues.webkit.org/results/6446004
zalan
Comment 7
2018-02-10 06:57:53 PST
Created
attachment 333556
[details]
Patch
WebKit Commit Bot
Comment 8
2018-02-10 07:44:31 PST
The commit-queue encountered the following flaky tests while processing
attachment 333556
[details]
: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-to-dataurl.html
bug 182270
(author:
youennf@gmail.com
) imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.https.html
bug 182396
(author:
youennf@gmail.com
) http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
bug 179840
(authors:
ap@webkit.org
and
rniwa@webkit.org
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9
2018-02-10 07:45:01 PST
Comment on
attachment 333556
[details]
Patch Clearing flags on attachment: 333556 Committed
r228365
: <
https://trac.webkit.org/changeset/228365
>
WebKit Commit Bot
Comment 10
2018-02-10 07:45:02 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug