Bug 182662 - [RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-09 15:57 PST by zalan
Modified: 2018-02-10 07:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (19.71 KB, patch)
2018-02-09 16:14 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.60 KB, patch)
2018-02-09 19:42 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.60 KB, patch)
2018-02-09 20:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.60 KB, patch)
2018-02-10 06:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-09 15:57:41 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-09 15:58:01 PST 
<rdar://problem/37408571>
Comment 2 zalan 2018-02-09 16:14:54 PST 
Created attachment 333531 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-02-09 16:16:52 PST 
Comment on attachment 333531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333531&action=review

> Source/WebCore/rendering/RenderBlock.cpp:499
> +    return builder.takenChildFromRenderBlock(*this, oldChild);

takeChild

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:473
> +RenderPtr<RenderObject> RenderTreeBuilder::takenChildFromRenderBlock(RenderBlock& parent, RenderObject& oldChild)

taken
Comment 4 zalan 2018-02-09 19:42:53 PST 
Created attachment 333549 [details]
Patch
Comment 5 zalan 2018-02-09 20:16:51 PST 
Created attachment 333551 [details]
Patch
Comment 6 WebKit Commit Bot 2018-02-10 06:52:40 PST 
Comment on attachment 333551 [details]
Patch

Rejecting attachment 333551 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 333551, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/6446004
Comment 7 zalan 2018-02-10 06:57:53 PST 
Created attachment 333556 [details]
Patch
Comment 8 WebKit Commit Bot 2018-02-10 07:44:31 PST 
The commit-queue encountered the following flaky tests while processing attachment 333556 [details]:

imported/w3c/web-platform-tests/fetch/api/redirect/redirect-to-dataurl.html bug 182270 (author: youennf@gmail.com)
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.https.html bug 182396 (author: youennf@gmail.com)
http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html bug 179840 (authors: ap@webkit.org and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2018-02-10 07:45:01 PST 
Comment on attachment 333556 [details]
Patch

Clearing flags on attachment: 333556

Committed r228365: <https://trac.webkit.org/changeset/228365>
Comment 10 WebKit Commit Bot 2018-02-10 07:45:02 PST 
All reviewed patches have been landed.  Closing bug.