Bug 182660 - [Cocoa] Web Automation: provide a way to ask clients the type of a JavaScript dialog
Summary: [Cocoa] Web Automation: provide a way to ask clients the type of a JavaScript...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-09 15:44 PST by BJ Burg
Modified: 2018-02-28 18:12 PST (History)
10 users (show)

See Also:

Attachments
Proposed Fix (10.16 KB, patch)
2018-02-09 17:13 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
For landing (11.57 KB, patch)
2018-02-21 12:13 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Fix internal build (11.62 KB, patch)
2018-02-28 14:59 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-02-09 15:44:12 PST 
Needed to properly implement W3C WebDriver, §18.4, Step 5 from the WebKit side.
Comment 1 Radar WebKit Bug Importer 2018-02-09 15:44:44 PST 
<rdar://problem/37408183>
Comment 3 BJ Burg 2018-02-09 17:13:17 PST 
Created attachment 333540 [details]
Proposed Fix
Comment 4 Carlos Garcia Campos 2018-02-10 00:41:12 PST 
Comment on attachment 333540 [details]
Proposed Fix

This looks good to me, r=me because patch is trivial, but maybe an Apple reviewer should check the new Cocoa API.
Comment 5 Tim Horton 2018-02-13 13:45:35 PST 
Comment on attachment 333540 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=333540&action=review

wk2r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h:64
> +- (_WKAutomationSessionJavaScriptDialogType)_automationSession:(_WKAutomationSession *)automationSession typeOfCurrentJavaScriptDialogOnPage:(WKPageRef)page;

These should still have availability macros, no?
Comment 6 BJ Burg 2018-02-13 13:50:18 PST 
Comment on attachment 333540 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=333540&action=review

>> Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h:64
>> +- (_WKAutomationSessionJavaScriptDialogType)_automationSession:(_WKAutomationSession *)automationSession typeOfCurrentJavaScriptDialogOnPage:(WKPageRef)page;
> 
> These should still have availability macros, no?

Hmm, yes. They shall match the availability of the related WKWebView delegate method above.
Comment 7 BJ Burg 2018-02-21 12:13:49 PST 
Created attachment 334402 [details]
For landing
Comment 8 WebKit Commit Bot 2018-02-21 15:31:20 PST 
Comment on attachment 334402 [details]
For landing

Clearing flags on attachment: 334402

Committed r228902: <https://trac.webkit.org/changeset/228902>
Comment 9 WebKit Commit Bot 2018-02-21 15:31:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Matt Lewis 2018-02-22 10:01:12 PST 
Reverted r228902 for reason:

This broke internal builds.

Committed r228920: <https://trac.webkit.org/changeset/228920>
Comment 11 BJ Burg 2018-02-28 14:59:33 PST 
Created attachment 334773 [details]
Fix internal build
Comment 12 WebKit Commit Bot 2018-02-28 18:12:36 PST 
Comment on attachment 334773 [details]
Fix internal build

Clearing flags on attachment: 334773

Committed r229117: <https://trac.webkit.org/changeset/229117>
Comment 13 WebKit Commit Bot 2018-02-28 18:12:37 PST 
All reviewed patches have been landed.  Closing bug.