Bug 182651 - [RenderTreeBuilder] Move RenderRubyAsInline/AsBlock::takeChild mutation to a RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderRubyAsInline/AsBlock::takeChild mutation to a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-09 14:24 PST by zalan
Modified: 2018-02-09 15:23 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.43 KB, patch)
2018-02-09 14:28 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.43 KB, patch)
2018-02-09 14:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-09 14:24:04 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2018-02-09 14:24:29 PST 
<rdar://problem/37405042>
Comment 2 zalan 2018-02-09 14:28:44 PST 
Created attachment 333516 [details]
Patch
Comment 3 Antti Koivisto 2018-02-09 14:30:57 PST 
Comment on attachment 333516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333516&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h:46
> +    RenderPtr<RenderObject>takeChild(RenderRubyAsBlock& parent, RenderObject& child);

Missing space after >
Comment 4 zalan 2018-02-09 14:34:31 PST 
Created attachment 333518 [details]
Patch
Comment 5 WebKit Commit Bot 2018-02-09 15:22:40 PST 
The commit-queue encountered the following flaky tests while processing attachment 333518 [details]:

imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.html bug 182270 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2018-02-09 15:23:07 PST 
Comment on attachment 333518 [details]
Patch

Clearing flags on attachment: 333518

Committed r228339: <https://trac.webkit.org/changeset/228339>
Comment 7 WebKit Commit Bot 2018-02-09 15:23:09 PST 
All reviewed patches have been landed.  Closing bug.