Bug 182646 - download-latest-github-release.py should not use "browser download URL".
Summary: download-latest-github-release.py should not use "browser download URL".
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-09 13:43 PST by Ross Kirsling
Modified: 2018-02-12 14:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.35 KB, patch)
2018-02-09 13:44 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (3.35 KB, patch)
2018-02-09 14:22 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (3.35 KB, patch)
2018-02-09 16:58 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (4.03 KB, patch)
2018-02-09 17:21 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-02-09 13:43:05 PST
download-latest-github-release .py should not use "browser download URL".
Comment 1 Ross Kirsling 2018-02-09 13:44:53 PST
Created attachment 333514 [details]
Patch
Comment 2 Ross Kirsling 2018-02-09 14:22:36 PST
Created attachment 333515 [details]
Patch
Comment 3 Ross Kirsling 2018-02-09 16:58:25 PST
Created attachment 333535 [details]
Patch
Comment 4 Ross Kirsling 2018-02-09 17:21:39 PST
Created attachment 333542 [details]
Patch
Comment 5 Ross Kirsling 2018-02-12 11:29:14 PST
WinCairo bot was in a bad state most of Friday, so this patch took a few resubmits to go green, but everything should be fine now.
Comment 6 Per Arne Vollan 2018-02-12 14:04:40 PST
Comment on attachment 333542 [details]
Patch

r=me.
Comment 7 WebKit Commit Bot 2018-02-12 14:38:02 PST
Comment on attachment 333542 [details]
Patch

Clearing flags on attachment: 333542

Committed r228396: <https://trac.webkit.org/changeset/228396>
Comment 8 WebKit Commit Bot 2018-02-12 14:38:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-02-12 14:39:25 PST
<rdar://problem/37474060>