Bug 182642 - Improve of string.h include after r228317.
Summary: Improve of string.h include after r228317.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-09 08:53 PST by Carlos Alberto Lopez Perez
Modified: 2018-02-09 10:04 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2018-02-09 09:04 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (1.25 KB, patch)
2018-02-09 09:06 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2018-02-09 08:53:49 PST 
From https://bugs.webkit.org/show_bug.cgi?id=182563#c22
> (In reply to Carlos Alberto Lopez Perez from comment #20)
> > Committed r228317: <https://trac.webkit.org/changeset/228317>
> 
> We should avoid architecture-specific #includes whenever possible. Adding
> one #include <string.h> is not going to slow down the build very much at
> all; it's not worth the cost of the include guards, IMO.
Comment 1 Carlos Alberto Lopez Perez 2018-02-09 09:04:29 PST 
Created attachment 333493 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2018-02-09 09:06:16 PST 
Created attachment 333494 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2018-02-09 10:03:07 PST 
Comment on attachment 333494 [details]
Patch

Clearing flags on attachment: 333494

Committed r228324: <https://trac.webkit.org/changeset/228324>
Comment 4 Carlos Alberto Lopez Perez 2018-02-09 10:03:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-09 10:04:26 PST 
<rdar://problem/37394750>