Bug 182628 - [RenderTreeBuilder] Move multicolumn descendant/sibling removal logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move multicolumn descendant/sibling removal logic to Rend...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-08 15:41 PST by zalan
Modified: 2018-02-09 10:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.27 KB, patch)
2018-02-08 15:48 PST, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (11.50 MB, application/zip)
2018-02-08 20:46 PST, EWS Watchlist 		no flags Details
Patch (11.73 KB, patch)
2018-02-09 09:41 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-08 15:41:15 PST 
all mutation will eventually end up there.
Comment 1 Radar WebKit Bug Importer 2018-02-08 15:41:57 PST 
<rdar://problem/37369528>
Comment 2 zalan 2018-02-08 15:48:22 PST 
Created attachment 333431 [details]
Patch
Comment 3 EWS Watchlist 2018-02-08 20:45:52 PST 
Comment on attachment 333431 [details]
Patch

Attachment 333431 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6424583

New failing tests:
http/tests/preload/onerror_event.html
Comment 4 EWS Watchlist 2018-02-08 20:46:02 PST 
Created attachment 333443 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 zalan 2018-02-08 20:55:59 PST 
(In reply to Build Bot from comment #3)
> Comment on attachment 333431 [details]
> Patch
> 
> Attachment 333431 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/6424583
> 
> New failing tests:
> http/tests/preload/onerror_event.html
I don't think so.
Comment 6 WebKit Commit Bot 2018-02-09 09:26:20 PST 
Comment on attachment 333431 [details]
Patch

Rejecting attachment 333431 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 333431, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ource/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
Hunk #1 succeeded at 367 with fuzz 1 (offset 196 lines).
patching file Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.h
Hunk #1 FAILED at 40.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6433366
Comment 7 zalan 2018-02-09 09:41:10 PST 
Created attachment 333496 [details]
Patch
Comment 8 WebKit Commit Bot 2018-02-09 10:31:35 PST 
Comment on attachment 333496 [details]
Patch

Clearing flags on attachment: 333496

Committed r228327: <https://trac.webkit.org/changeset/228327>
Comment 9 WebKit Commit Bot 2018-02-09 10:31:36 PST 
All reviewed patches have been landed.  Closing bug.