Bug 182625 - Support GetArrayLength on ArrayStorage in the FTL
Summary: Support GetArrayLength on ArrayStorage in the FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 182731
  Show dependency tree / graph
 
Reported: 2018-02-08 14:24 PST by Saam Barati
Modified: 2018-02-13 10:39 PST (History)
12 users (show)

See Also:

Attachments
Patch (8.75 KB, patch)
2018-02-13 06:24 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-02-08 14:24:40 PST 
Right now we don't. I see that some JetStream subtest runs into this.
Comment 1 Yusuke Suzuki 2018-02-13 02:10:45 PST 
(In reply to Saam Barati from comment #0)
> Right now we don't. I see that some JetStream subtest runs into this.

Actually, we can see bunch of giving up FTL compilation in web-tooling-benchmark due to the lack of ArrayStorage support in operations (PutByVal etc.).
Now FTL can compile even an Eval node. FTL coverage should be expanded :)
Comment 2 Yusuke Suzuki 2018-02-13 06:24:23 PST 
Created attachment 333684 [details]
Patch
Comment 3 Saam Barati 2018-02-13 09:11:16 PST 
Comment on attachment 333684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333684&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        This fixes several FTL failures in web-tooling-benchmarks while we still need to support ArrayPush,

FTL failures => FTL compilation failures
Comment 4 Yusuke Suzuki 2018-02-13 09:20:08 PST 
Comment on attachment 333684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333684&action=review

Thank you.

>> Source/JavaScriptCore/ChangeLog:11
>> +        This fixes several FTL failures in web-tooling-benchmarks while we still need to support ArrayPush,
> 
> FTL failures => FTL compilation failures

Fixed.
Comment 5 Yusuke Suzuki 2018-02-13 09:29:12 PST 
Committed r228421: <https://trac.webkit.org/changeset/228421>
Comment 6 Radar WebKit Bug Importer 2018-02-13 09:30:25 PST 
<rdar://problem/37500450>