RESOLVED FIXED 182624
Switch http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html from testRunner.installStatisticsDidModifyDataRecordsCallback() to testRunner.installStatisticsDidScanDataRecordsCallback() 
https://bugs.webkit.org/show_bug.cgi?id=182624
Summary Switch http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie...
John Wilander
Reported 2018-02-08 13:57:55 PST
We should switch from testRunner.installStatisticsDidModifyDataRecordsCallback() to testRunner.installStatisticsDidScanDataRecordsCallback() in http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html to make it not be a flaky timeout.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-08 13:58:26 PST
<rdar://problem/37364749>
John Wilander
Comment 2 2018-02-08 14:00:50 PST
Committed r228294: <https://trac.webkit.org/changeset/228294>
Ryan Haddad
Comment 3 2018-02-09 16:33:57 PST
Good news: the test isn't a flaky timeout anymore. Bad news: it is a flaky failure. --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion-actual.txt @@ -27,13 +27,13 @@ -------- After removal, should receive no cookies. Did not receive cookie named 'firstPartyCookie'. -Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: +Received cookie named 'thirdPartyCookie'. +Client-side document.cookie: thirdPartyCookie=value -------- Frame: '<!--framePath //<!--frame4-->-->' -------- After user interaction, should receive no cookies. -Did not receive cookie named 'firstPartyCookie'. +Received cookie named 'firstPartyCookie'. Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: +Client-side document.cookie: firstPartyCookie=value https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r228318%20(2007)/results.html
John Wilander
Comment 4 2018-02-09 17:08:12 PST
I think I understand why this happens. This is down to flakiness of cookies. Earlier, we sometimes didn't get the notification of data records removal so we timed out. Now we instead wait for a notification of data records scanning which sometimes fires before removal has finished underneath us. So cookies are still there. :(
Matt Lewis
Comment 5 2018-02-12 15:59:21 PST
Marked as flaky in https://trac.webkit.org/changeset/228403/webkit
Note You need to log in before you can comment on or make changes to this bug.