Bug 182624 - Switch http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html from testRunner.installStatisticsDidModifyDataRecordsCallback() to testRunner.installStatisticsDidScanDataRecordsCallback()
Summary: Switch http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
Keywords: InRadar
Depends on:
Reported: 2018-02-08 13:57 PST by John Wilander
Modified: 2018-02-12 16:09 PST (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-02-08 13:57:55 PST
We should switch from testRunner.installStatisticsDidModifyDataRecordsCallback() to testRunner.installStatisticsDidScanDataRecordsCallback() in http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html to make it not be a flaky timeout.
Comment 1 Radar WebKit Bug Importer 2018-02-08 13:58:26 PST
Comment 2 John Wilander 2018-02-08 14:00:50 PST
Committed r228294: <https://trac.webkit.org/changeset/228294>
Comment 3 Ryan Haddad 2018-02-09 16:33:57 PST
Good news: the test isn't a flaky timeout anymore.

Bad news: it is a flaky failure.

--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion-actual.txt
@@ -27,13 +27,13 @@
 After removal, should receive no cookies.
 Did not receive cookie named 'firstPartyCookie'.
-Did not receive cookie named 'thirdPartyCookie'.
-Client-side document.cookie:
+Received cookie named 'thirdPartyCookie'.
+Client-side document.cookie: thirdPartyCookie=value
 Frame: '<!--framePath //<!--frame4-->-->'
 After user interaction, should receive no cookies.
-Did not receive cookie named 'firstPartyCookie'.
+Received cookie named 'firstPartyCookie'.
 Did not receive cookie named 'thirdPartyCookie'.
-Client-side document.cookie:
+Client-side document.cookie: firstPartyCookie=value

Comment 4 John Wilander 2018-02-09 17:08:12 PST
I think I understand why this happens. This is down to flakiness of cookies. Earlier, we sometimes didn't get the notification of data records removal so we timed out. Now we instead wait for a notification of data records scanning which sometimes fires before removal has finished underneath us. So cookies are still there. :(
Comment 5 Matt Lewis 2018-02-12 15:59:21 PST
Marked as flaky in https://trac.webkit.org/changeset/228403/webkit