Bug 182612 – [GStreamer][WebAudio] Winamp2-js woes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

https://jordaneldredge.com/projects/winamp2-js/ doesn't behave well in wkgtk.

[Philippe Normand]

Created attachment 333405 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 333405 [details]
Patch

It will be nice to have also some test case, not sure how hard is to write it.

[Philippe Normand]

Created attachment 333476 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 333476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333476&action=review

> LayoutTests/webaudio/silence-after-playback.html:13
> +         description("Test ensuring silence is outputed after <audio> playback ended.");

I think outputed does not exist, only output.

> LayoutTests/webaudio/silence-after-playback.html:17
> +         var context = 0;
> +         var sampleRate = 44100.0;
> +         var lengthInSeconds = 3;

I would recommend switching var to const instead of context, that would use let and leave it uninitialized until it is done in runTest.

[Philippe Normand]

(In reply to Xabier Rodríguez Calvar from comment #4)
> Comment on attachment 333476 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=333476&action=review
> 
> > LayoutTests/webaudio/silence-after-playback.html:13
> > +         description("Test ensuring silence is outputed after <audio> playback ended.");
> 
> I think outputed does not exist, only output.
> 

Ok

> > LayoutTests/webaudio/silence-after-playback.html:17
> > +         var context = 0;
> > +         var sampleRate = 44100.0;
> > +         var lengthInSeconds = 3;
> 
> I would recommend switching var to const instead of context, that would use
> let and leave it uninitialized until it is done in runTest.

I don't understand this comment. The var context = 0; comes from another webaudio test, I don't see what's wrong with it :)

[EWS Watchlist]

Comment on attachment 333476 [details]
Patch

Attachment 333476 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6430867

New failing tests:
webaudio/silence-after-playback.html

[EWS Watchlist]

Created attachment 333478 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 333476 [details]
Patch

Attachment 333476 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6430879

New failing tests:
webaudio/silence-after-playback.html

[EWS Watchlist]

Created attachment 333479 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Philippe Normand]

Created attachment 333480 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 333480 [details]
Patch

Thanks for the test!

[Philippe Normand]

Committed r228321: <https://trac.webkit.org/changeset/228321>